Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Column Sketches to Bliss #55

Merged
merged 7 commits into from
Feb 21, 2025
Merged

Conversation

altramarine
Copy link
Contributor

No description provided.

@altramarine altramarine requested review from ramananeesh, ephoris and JslYoon and removed request for ramananeesh and JslYoon February 6, 2025 14:34
Copy link
Collaborator

@ramananeesh ramananeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just left a small comment but overall LGTM 👍

Copy link
Collaborator

@ephoris ephoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll want to make some of the compile options optional.

@ramananeesh ramananeesh linked an issue Feb 14, 2025 that may be closed by this pull request
Copy link
Collaborator

@ramananeesh ramananeesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@ephoris ephoris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me!

@altramarine altramarine merged commit 4281f2c into main Feb 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate range lookups in column sketches
3 participants