Skip to content

Correct some misspellings thoughout Babylon #16583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dev/core/src/FrameGraph/Node/nodeRenderGraph.ts
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ export class NodeRenderGraph {
}

/**
* Disposes the ressources
* Disposes the resources
*/
public dispose(): void {
for (const block of this.attachedBlocks) {
Expand Down
6 changes: 3 additions & 3 deletions packages/dev/core/src/Helpers/environmentHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -516,9 +516,9 @@ export class EnvironmentHelper {
skyboxSize = groundSize;
}

const sceneDiagonalLenght = sceneDiagonal.length();
if (sceneDiagonalLenght > groundSize) {
groundSize = sceneDiagonalLenght * 2;
const sceneDiagonalLength = sceneDiagonal.length();
if (sceneDiagonalLength > groundSize) {
groundSize = sceneDiagonalLength * 2;
skyboxSize = groundSize;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/dev/core/src/Meshes/Node/nodeGeometry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ export class NodeGeometry {
}

/**
* Disposes the ressources
* Disposes the resources
*/
public dispose(): void {
for (const block of this.attachedBlocks) {
Expand Down
12 changes: 6 additions & 6 deletions packages/dev/core/src/Offline/database.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class Database implements IOfflineProvider {
private _enableSceneOffline: boolean;
private _enableTexturesOffline: boolean;
private _manifestVersionFound: number;
private _mustUpdateRessources: boolean;
private _mustUpdateResources: boolean;
private _hasReachedQuota: boolean;
private _isSupported: boolean;

Expand Down Expand Up @@ -62,7 +62,7 @@ export class Database implements IOfflineProvider {
this._enableSceneOffline = false;
this._enableTexturesOffline = false;
this._manifestVersionFound = 0;
this._mustUpdateRessources = false;
this._mustUpdateResources = false;
this._hasReachedQuota = false;

if (!Database.IDBStorageEnabled) {
Expand Down Expand Up @@ -268,7 +268,7 @@ export class Database implements IOfflineProvider {
}
};

if (!this._mustUpdateRessources) {
if (!this._mustUpdateResources) {
this._loadImageFromDB(completeURL, image, saveAndLoadImage);
}
// First time we're download the images or update requested in the manifest file by a version change
Expand Down Expand Up @@ -437,15 +437,15 @@ export class Database implements IOfflineProvider {
if (version) {
// If the version in the JSON file is different from the version in DB
if (this._manifestVersionFound !== version.data) {
this._mustUpdateRessources = true;
this._mustUpdateResources = true;
updateInDBCallback();
} else {
callback(version.data);
}
}
// version was not found in DB
else {
this._mustUpdateRessources = true;
this._mustUpdateResources = true;
updateInDBCallback();
}
};
Expand Down Expand Up @@ -530,7 +530,7 @@ export class Database implements IOfflineProvider {

this._checkVersionFromDB(completeUrl, (version) => {
if (version !== -1) {
if (!this._mustUpdateRessources) {
if (!this._mustUpdateResources) {
this._loadFile(completeUrl, sceneLoaded, saveAndLoadFile, progressCallBack);
} else {
this._saveFile(completeUrl, sceneLoaded, progressCallBack, useArrayBuffer, errorCallback);
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/core/src/Rendering/depthPeelingRenderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,7 @@ export class DepthPeelingRenderer {
}

/**
* Disposes the depth peeling renderer and associated ressources
* Disposes the depth peeling renderer and associated resources
*/
public dispose() {
this._disposeTextures();
Expand Down
4 changes: 2 additions & 2 deletions packages/dev/core/src/Rendering/edgesRenderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ export class EdgesRenderer implements IEdgesRenderer {
this._shaderLanguage = ShaderLanguage.WGSL;
}

this._prepareRessources();
this._prepareResources();
if (generateEdgesLines) {
if (options?.useAlternateEdgeFinder ?? true) {
this._generateEdgesLinesAlternate();
Expand All @@ -333,7 +333,7 @@ export class EdgesRenderer implements IEdgesRenderer {
});
}

protected _prepareRessources(): void {
protected _prepareResources(): void {
if (this._lineShader) {
return;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ export class FluidRenderer {
}

/**
* Disposes of all the ressources used by the class
* Disposes of all the resources used by the class
*/
public dispose(): void {
this._engine.onResizeObservable.remove(this._onEngineResizeObserver);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ export abstract class FluidRenderingObject {
}

/**
* Releases the ressources used by the class
* Releases the resources used by the class
*/
public dispose(): void {
this._depthEffectWrapper?.dispose(false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export class FluidRenderingObjectCustomParticles extends FluidRenderingObject {
}

/**
* Releases the ressources used by the class
* Releases the resources used by the class
*/
public override dispose(): void {
super.dispose();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export class FluidRenderingObjectParticleSystem extends FluidRenderingObject {
}

/**
* Releases the ressources used by the class
* Releases the resources used by the class
*/
public override dispose() {
super.dispose();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -956,8 +956,8 @@ export class FluidRenderingTargetRenderer {
}

/**
* Releases all the ressources used by the class
* @param onlyPostProcesses If true, releases only the ressources used by the render post processes
* Releases all the resources used by the class
* @param onlyPostProcesses If true, releases only the resources used by the render post processes
*/
public dispose(onlyPostProcesses = false): void {
if (!onlyPostProcesses) {
Expand Down
2 changes: 1 addition & 1 deletion packages/dev/core/src/sceneComponent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export interface ISceneComponent {
rebuild(): void;

/**
* Disposes the component and the associated ressources.
* Disposes the component and the associated resources.
*/
dispose(): void;
}
Expand Down
6 changes: 3 additions & 3 deletions packages/tools/viewer-legacy/src/managers/sceneManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1000,9 +1000,9 @@ export class SceneManager {
this.camera.beta = (this._globalConfiguration.camera && this._globalConfiguration.camera.beta) || this.camera.beta;
this.camera.radius = (this._globalConfiguration.camera && this._globalConfiguration.camera.radius) || this.camera.radius;

const sceneDiagonalLenght = sizeVec.length();
if (isFinite(sceneDiagonalLenght)) {
this.camera.upperRadiusLimit = sceneDiagonalLenght * 4;
const sceneDiagonalLength = sizeVec.length();
if (isFinite(sceneDiagonalLength)) {
this.camera.upperRadiusLimit = sceneDiagonalLength * 4;
}

if (this._configurationContainer.configuration) {
Expand Down