Adopt Golem framework #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: remove all the roxygen import statements as we follow the package::function nomenclature and therefore is not needed feature: start using README.Rmd instead of README.md. Use the toc functionality instead of <div> elements refactor: update Dockerfile to work with the new golem structure (run_app) refactor: extract JS code into its separate file refactor: remove zzz.R as it was not needed anymore
refactor: add devtools::build_readme reference in the 02_dev.R file
…migration-to-golem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces changes to adopt Golem as a framework to develop Shiny apps. The main changes are reflected in the split of ui and server logic into separate files, and the usage of certain development scripts that can simplify the development process. These can be found under
devfolder.The PR also takes advantage and addresses certain problems with NAMESPACE and dependencies. Since our guideline says that we should use functions from external packages as
package::fun(), we don't need to include@importFromstatements for every function that is being used in our code. The only exception to this is the usage of pipes and the.datasymbol from therlangpackage. These indeed have to be imported. To do so, we have followed the recommendation of having a{packagename}-package.Rscript that includes all the necessary@importFromstatements in a centralized place.The version of R has been set in the DESCRIPTION file so warnings do not appear when running devtools::check. As we are using
data-raw, we need to set a minimum version for R.The README is now generated using README.Rmd. The zzz.R files has been removed as it was not needed anymore.