Replaces legacy event logging with tracing system#132
Open
FlorianSiBeckhoff wants to merge 7 commits into
Open
Replaces legacy event logging with tracing system#132FlorianSiBeckhoff wants to merge 7 commits into
FlorianSiBeckhoff wants to merge 7 commits into
Conversation
added 3 commits
March 30, 2026 14:54
Introduces a standardized tracing system to the XTS base project, supporting both ADS and TwinCAT Event Logger outputs. The system uses a publisher-subscriber architecture with configurable severity levels and throttling to manage diagnostic message flow.
Standardizes tracing naming conventions and extracts event definitions to a dedicated TMC file. Updates the Mover function block to use the centralized tracing system instead of direct event calls and fixes a parameter ordering bug in the ADS logger.
Removes the dependency on TwinCAT Event Logger and the associated TMC file. Updates Mover, Mediator, and PositionTrigger to use the centralized Trace system for diagnostic messaging. The LogUserEvent method has been removed from the iMover interface as part of this transition.
Collaborator
|
This is a great upgrade! I did notice that the ErrorMover object needs to be converted to the new event logging structure for consistency. Also, I don't know if this can be resolved at this point, but there is a lot of whitespace diff churn. |
Author
I did update the ErrorMover - good catch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Features:
Introduces a flexible and configurable tracing system to enhance diagnostics and monitoring.