refactor: improve pretty_legend!

Beforerr · Nov 10, 2024 · aadcd87 · aadcd87
1 parent 4ecaaba
commit aadcd87
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/makie/makie.jl b/src/makie/makie.jl
@@ -61,13 +61,10 @@ end
 # -----
 # Position
 # -----
-
-default_titleposition(position) = position in [:top, :bottom] ? :left : :top
-
 """
     guides_position(f, position)
 
-Return the position of the guides for the given `position` in the `f`.
+Return the position of the guides (like colorbar) for the given `position` in the `f`.
 """
 function guides_position(f, position)
     @match Symbol(position) begin

diff --git a/src/utils/aog.jl b/src/utils/aog.jl
@@ -21,8 +21,9 @@ cdraw!(f::Union{GridPosition,GridSubposition}, args...; kw...) = cdraw!(GridLayo
 
 
 """Add a legend to the figure grid `fg`, with the default legend positioned at the top"""
-function pretty_legend!(fg::FigureGrid; position=:top, titleposition=default_titleposition(position), kwargs...)
-    legend!(fg; position=position, titleposition=titleposition, kwargs...)
+function pretty_legend!(fg::FigureGrid; position=:top, kwargs...)
+    titleposition = position in (:top, :bottom) ? :left : :top
+    legend!(fg; position, titleposition, kwargs...)
 end
 
 """Add a legend to the figure"""