Cherry puck #10
Merged
Cherry puck #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather then calling a proc every time we want to know if we're incap or not, let's store all possible responses as a bitflag and update a var whenever we change. This way we can react to incap changes in an event based way! Now to do the mass updating
Regexes used: incapacitated\(\) -> incapacitated incapacitated\(([^\)]*)\) -> (incapacitated & $1) I wrapped the flag bits with () cause I don't trust binary ops
…n off ai work We've reached the point where we have a TON of basic mobs. we need to start microing the plumbing that they flow through so we can continue using them at scale
Includes a macro to make it easier to reason about. Also moved all my signal stuff to init_signals, rip setup_incapacitated()
|
Cherry pick* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Why It's Good For The Game
Changelog
🆑
add: Added new mechanics or gameplay changes
add: Added more things
del: Removed old things
qol: made something easier to use
balance: rebalanced something
fix: fixed a few things
sound: added/modified/removed audio or sound effects
image: added/modified/removed some icons or images
spellcheck: fixed a few typos
code: changed some code
refactor: refactored some code
config: changed some config setting
admin: messed with admin stuff
server: something server ops should know
/:cl: