fix: remove recursive call #8225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
theGitNoob
force-pushed
the
fix/together_recursive_call
branch
from
d2df5bf to
9db90b5
Compare
| @@ -4362,6 +4357,25 @@ def _get_model_info_helper( # noqa: PLR0915 | |||
| ) | |||
|
|
|||
|
|
|||
| def get_model_param_support( | |||
There was a problem hiding this comment.
hey @theGitNoob introducing a 2nd way of checking the model cost map is not preferable because it adds more scope for errors.
Ideally it is just using one flow - get_model_info()
i believe a workaround to avoid the recursive function is to use the underlying helper -
Line 4142 in 302cc4f
There was a problem hiding this comment.
bump on this @theGitNoob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Remove recursive call from together
Relevant issues
"Fixes #8223"
Type
🐛 Bug Fix
Changes
Added new method
This pull request removes unnecessary recursive call inside
litellm.llms.together_ai.chat.TogetherAIConfigCode Refactoring:
litellm/llms/together_ai/chat.py: Replaced theget_model_infoimport withget_model_param_supportfromlitellm.utilsand updated theget_supported_openai_paramsmethod to use this new utility function. [1]litellm/utils.py: Added a new utility functionget_model_param_supportto retrieve model parameters .[1]Data Updates:
litellm/model_prices_and_context_window_backup.json: Updated themax_input_tokensfor several models to correct values and addeddeprecation_datefor certain models. [1] [2] [3] [4] [5] [6] [7] [8] [9][REQUIRED] Testing - Attach a screenshot of any new tests passing locally
If UI changes, send a screenshot/GIF of working UI fixes