Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent tools override #8273

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

m1heng
Copy link

@m1heng m1heng commented Feb 5, 2025

Title

Prevent tool def override when response format and tool def are given at same time.

Relevant issues

None

Type

🐛 Bug Fix

Changes

  • align behavior with anthropic transformation

[REQUIRED] Testing - Attach a screenshot of any new tests passing locally

If UI changes, send a screenshot/GIF of working UI fixes

Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 8:48am

@krrishdholakia
Copy link
Contributor

krrishdholakia commented Feb 7, 2025

hey @m1heng i just had to do this for azure -

optional_params = self._add_response_format_to_tools(

Can you use the base config's _add_response_format_to_tools for this

It seems like a common error across providers


If you have any suggestions for improving the design here, feel free to make it in your PR!

@krrishdholakia
Copy link
Contributor

cc: @ishaan-jaff as this is relevant to your qa work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants