Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feat) - Allow calling Nova models on /bedrock/invoke/ #8397

Merged
merged 14 commits into from
Feb 8, 2025
Prev Previous commit
Next Next commit
test_nova_invoke_remove_empty_system_messages
ishaan-jaff committed Feb 8, 2025
commit c4c9659192856ce46081082c9deb465db4df7207
43 changes: 43 additions & 0 deletions tests/llm_translation/test_bedrock_invoke_tests.py
Original file line number Diff line number Diff line change
@@ -3,10 +3,12 @@
import sys
import os


sys.path.insert(
0, os.path.abspath("../..")
) # Adds the parent directory to the system path
import litellm
from litellm.types.llms.bedrock import BedrockInvokeNovaRequest


class TestBedrockInvokeClaudeJson(BaseLLMChatTest):
@@ -45,3 +47,44 @@ def skip_non_json_tests(self, request):
pytest.skip(
f"Skipping non-JSON test: {request.function.__name__} does not contain 'json'"
)


def test_nova_invoke_remove_empty_system_messages():
"""Test that _remove_empty_system_messages removes empty system list."""
input_request = BedrockInvokeNovaRequest(
messages=[{"content": [{"text": "Hello"}], "role": "user"}],
system=[],
inferenceConfig={"temperature": 0.7},
)

litellm.AmazonInvokeNovaConfig()._remove_empty_system_messages(input_request)

assert "system" not in input_request
assert "messages" in input_request
assert "inferenceConfig" in input_request


def test_nova_invoke_filter_allowed_fields():
"""
Test that _filter_allowed_fields only keeps fields defined in BedrockInvokeNovaRequest.
Nova Invoke does not allow `additionalModelRequestFields` and `additionalModelResponseFieldPaths` in the request body.
This test ensures that these fields are not included in the request body.
"""
_input_request = {
"messages": [{"content": [{"text": "Hello"}], "role": "user"}],
"system": [{"text": "System prompt"}],
"inferenceConfig": {"temperature": 0.7},
"additionalModelRequestFields": {"this": "should be removed"},
"additionalModelResponseFieldPaths": ["this", "should", "be", "removed"],
}

input_request = BedrockInvokeNovaRequest(**_input_request)

result = litellm.AmazonInvokeNovaConfig()._filter_allowed_fields(input_request)

assert "additionalModelRequestFields" not in result
assert "additionalModelResponseFieldPaths" not in result
assert "messages" in result
assert "system" in result
assert "inferenceConfig" in result