Skip to content

fix: 루트 build.gradle에서 google 플러그인 제거#283

Merged
HeesooJun merged 1 commit intodevelopfrom
build
Oct 19, 2025
Merged

fix: 루트 build.gradle에서 google 플러그인 제거#283
HeesooJun merged 1 commit intodevelopfrom
build

Conversation

@HeesooJun
Copy link
Copy Markdown
Contributor

https://firebase.google.com/docs/android/setup?hl=ko#groovy

공식문서에 따르면
루트 수준: 플러그인 종속 추가만 함
모듈(앱) 수준: 플러그인 적용

루트 수준에 있는 플러그인을 제거함으로써 초기 빌드 오류를 예방합니다.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @HeesooJun, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 빌드 구성에서 google-services 플러그인의 적용 방식을 수정하는 것을 목표로 합니다. 앱 모듈의 루트 수준 build.gradle 파일에서 해당 플러그인을 제거함으로써, Firebase의 공식 가이드라인을 준수하고 잠재적인 빌드 문제를 방지하여 보다 견고한 빌드 프로세스를 보장합니다.

Highlights

  • Google 서비스 플러그인 설정 수정: Firebase 공식 문서에 따라 com.google.gms.google-services 플러그인이 루트 수준 build.gradle 파일에서 제거되었습니다. 이 플러그인은 모듈(앱) 수준에서 적용되어야 하며, 루트 수준에서의 적용은 초기 빌드 오류를 유발할 수 있습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

이 PR은 루트 build.gradle 파일에서 불필요한 com.google.gms.google-services 플러그인 적용을 제거하는 변경 사항을 담고 있습니다. Firebase 공식 문서에 따라, 해당 플러그인은 모듈(앱) 수준의 build.gradle 파일에만 적용되어야 합니다. 이미 apps/app/android/app/build.gradle에 플러그인이 적용되어 있으므로, 이 변경은 중복을 제거하고 잠재적인 빌드 오류를 예방하는 올바른 수정입니다. 좋은 수정입니다.

@HeesooJun HeesooJun merged commit 30a724f into develop Oct 19, 2025
2 checks passed
@HeesooJun HeesooJun deleted the build branch October 19, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants