Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates #2395

Merged
merged 2 commits into from
Dec 10, 2024
Merged

updates #2395

merged 2 commits into from
Dec 10, 2024

Conversation

ponderingdemocritus
Copy link
Contributor

@ponderingdemocritus ponderingdemocritus commented Dec 10, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Updated environment variables to point to the new sepolia-rc-17 endpoints for the Torii service.
    • Enhanced onboarding experience with improved Terms of Service display and navigation.
  • Bug Fixes

    • Removed unused countdown logic from the application, streamlining the context provider.
  • Chores

    • Updated deployment configurations to reflect changes for the sepolia-rc-17 network, including environment file adjustments and manifest updates.
    • Modified scripts and configuration files to ensure alignment with the new deployment strategy.

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eternum ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:47pm
eternum-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 11:47pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
eternum-landing ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 11:47pm

Copy link
Contributor

coderabbitai bot commented Dec 10, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request primarily involve updates to environment variables, modifications to the countdown logic, and adjustments in the onboarding layout. Environment variables in both client/.env.preview and landing/.env.preview were updated to reference a new release candidate version. The CountdownTimer component was removed from the DojoContext, and the useSeasonStart hook was altered to use useMemo instead of useEffect. Additionally, the onboarding layout was enhanced for better user interaction regarding the Terms of Service. Configuration files were also updated to reflect these changes.

Changes

File Path Change Summary
client/.env.preview Updated VITE_PUBLIC_TORII, VITE_PUBLIC_TORII_RELAY, and VITE_PUBLIC_SLOT to sepolia-rc-17.
landing/.env.preview Updated VITE_PUBLIC_TORII and VITE_PUBLIC_TORII_RELAY to sepolia-rc-17.
client/src/hooks/context/DojoContext.tsx Removed CountdownTimer component and useSeasonStart hook; simplified rendering logic.
client/src/hooks/useSeasonStart.tsx Replaced useEffect with useMemo for countdown logic; removed timer functionality.
client/src/ui/layouts/Onboarding.tsx Enhanced StepContainer for conditional rendering of Terms of Service and "Back" button.
config/index.ts Updated production manifest import to manifest_prod.json; expanded setupConfig structure.
contracts/dojo_prod.toml Updated seed value from s0_eternum-10 to s0_eternum-11.
contracts/manifest_prod.json Updated various contract addresses and seed in world object.
scripts/deploy.sh Changed deployment target to sepolia-rc-17 and updated related configurations.
landing/src/hooks/use-season-start.tsx Removed useEffect logic for countdown; now returns static values.
season_resources/scripts/deployment/config/index.ts Updated import for production manifest to manifest_prod.json.
season_resources/scripts/deployment/libs/commands.js Updated import for production manifest to manifest_prod.json; ensured error handling for resource addresses.

Possibly related PRs

  • env #1973: This PR updates environment variables in the client/.env.preview file, including changes to VITE_PUBLIC_TORII and VITE_PUBLIC_TORII_RELAY, which are also modified in the main PR.
  • implements zod env checking #2138: This PR adds new environment variables related to the Torii service, including updates to VITE_PUBLIC_TORII and VITE_PUBLIC_TORII_RELAY, which are relevant to the changes in the main PR.
  • feat: add countdown backdrop to client page #2383: This PR introduces a CountdownTimer component that is rendered conditionally based on the countdown value, which relates to the changes made in the main PR regarding the countdown functionality.
  • Fix/wonders lords cost #2384: This PR modifies the SelectPreviewBuilding component to adjust costs based on the presence of a wonder, which may relate to the overall context of resource management in the main PR.
  • update ToS #2391: This PR updates the TermsOfService component, which may relate to the onboarding process and user interactions discussed in the main PR.

Suggested reviewers

  • edisontim
  • bob0005

Poem

In the burrow where changes bloom,
New paths emerge, dispelling gloom.
With Torii's call, we leap and play,
Countdown fades, we find our way.
Onboarding bright, with terms to see,
Hopping forward, wild and free! 🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4f6a020 and 549f68f.

📒 Files selected for processing (12)
  • client/.env.preview (1 hunks)
  • client/src/hooks/context/DojoContext.tsx (3 hunks)
  • client/src/hooks/useSeasonStart.tsx (1 hunks)
  • client/src/ui/layouts/Onboarding.tsx (1 hunks)
  • config/index.ts (3 hunks)
  • contracts/dojo_prod.toml (1 hunks)
  • contracts/manifest_prod.json (26 hunks)
  • landing/.env.preview (1 hunks)
  • landing/src/hooks/use-season-start.tsx (1 hunks)
  • scripts/deploy.sh (1 hunks)
  • season_resources/scripts/deployment/config/index.ts (1 hunks)
  • season_resources/scripts/deployment/libs/commands.js (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

mentatbot bot commented Dec 10, 2024

You are out of MentatBot reviews. Your usage will refresh December 16 at 08:00 AM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant