Set default value to max + filter out 0 balance resources

[bob0005]

Summary by CodeRabbit

• New Features

  • Enhanced resource management by dynamically calculating resource amounts based on available balances.
  • Updated resource selection to filter out resources with a balance of 0, improving user experience.

• Style

  • Minor formatting adjustments for consistency in code structure.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
eternum	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 27, 2024 4:19pm
eternum-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 27, 2024 4:19pm
eternum-landing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 27, 2024 4:19pm

[coderabbitai]

Walkthrough

The pull request modifies the SelectResources.tsx component to improve resource amount initialization and management. The changes focus on dynamically calculating initial resource amounts using the divideByPrecision function and getBalance method. Additionally, the resource selection options are now filtered to exclude resources with zero balance, ensuring only available resources can be selected.

Changes

File	Change Summary
landing/src/components/ui/SelectResources.tsx	- Updated resource amount initialization in addResourceGive functions - Modified resource selection options to filter out zero-balance resources - Minor formatting improvements in object destructuring

Poem

🐰 Hop, hop, resources in sight,
Balances dancing, calculations just right!
No more zero, only wealth so bright,
CodeRabbit's magic takes playful flight,
Precision leaps with algorithmic might! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5058962 and 8ac94d9.

📒 Files selected for processing (1)

• landing/src/components/ui/SelectResources.tsx (8 hunks)

🔇 Additional comments (10)

landing/src/components/ui/SelectResources.tsx (10)

24-24: Check for potential null/undefined returns from useResourceBalance.
Ensure getBalance gracefully handles cases where the entity might not exist or the API call fails, to prevent runtime errors.

Would you like me to generate a fallback mechanism, such as returning 0 if getBalance is undefined?

---

35-35: Validate index access on unselectedResources[0].
Calling unselectedResources[0] assumes at least one resource exists. If unselectedResources is empty, this will throw. Consider adding conditional checks to avoid errors when no resources remain.

---

43-48: Confirm that filtered zero-balance resources are correctly excluded.
The .filter((res) => getBalance(res.id) > 0) logic aligns with the PR objective to exclude resources with zero balance. Make sure your design accounts for any edge case where getBalance might return undefined.

---

78-78: Ensure correct value in onChange handler.
The updated resource amount is derived from getBalance(value). Validate that value is indeed a valid resource ID and that getBalance is never null or undefined.

---

120-120: Check for potential null/undefined returns from useResourceBalance.
Same comment as line 24. Make sure we have fallback handling if getBalance is undefined.

---

137-137: Validate index access on unselectedResources[0].
Same concern as line 35. Ensure unselectedResources is not empty to avoid uncaught errors.

---

145-150: Filter out zero-balance resources consistently.
This snippet mirrors the approach in SelectResources; using .filter((res) => getBalance(res.id) > 0) to skip unavailable resources. Looks good. Just be mindful of potential null returns from getBalance.

---

168-168: Double-check that value is never null or invalid.
Same comment as line 78. Make sure the newly selected resource key is valid before calling getBalance(value).

---

221-221: Check for potential null/undefined returns from useResourceBalance.
Same comment as line 24/120. Ensure that if getBalance is not returned, we default to 0 or handle the error.

---

238-238: Validate index access on unselectedResources[0].
Same concern as line 35/137. Handling the case when no more unselected resources are left would prevent potential errors.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Failed to generate code suggestions for PR