-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update policies #2658
Merged
Merged
Update policies #2658
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| import { readFileSync, writeFileSync } from "fs"; | ||
| import ts from "typescript"; | ||
|
|
||
| const MANIFEST_PATHS = { | ||
| local: "../contracts/game/manifest_local.json", | ||
| slot: "../contracts/game/manifest_slot.json", | ||
| sepolia: "../contracts/game/manifest_sepolia.json", | ||
| mainnet: "../contracts/game/manifest_mainnet.json", | ||
| }; | ||
|
|
||
| const policiesPath = "apps/game/src/hooks/context/policies.ts"; | ||
|
|
||
| function updatePoliciesWithManifestAddresses(network, policiesPath) { | ||
| if (!Object.keys(MANIFEST_PATHS).includes(network)) { | ||
| throw new Error(`Invalid network. Must be one of: ${Object.keys(MANIFEST_PATHS).join(', ')}`); | ||
| } | ||
|
|
||
| const manifestPath = MANIFEST_PATHS[network]; | ||
|
|
||
| const manifestData = JSON.parse(readFileSync(manifestPath, "utf8")); | ||
| const fileContent = readFileSync(policiesPath, "utf8"); | ||
|
|
||
| const sourceFile = ts.createSourceFile(policiesPath, fileContent, ts.ScriptTarget.Latest, true); | ||
|
|
||
| function findAddressForSystem(systemName) { | ||
| for (const contract of manifestData.contracts) { | ||
| if (contract.systems && contract.systems.includes(systemName)) { | ||
| return contract.address; | ||
| } | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| let updatedContent = fileContent; | ||
|
|
||
| function updateAddressesInPolicies(node) { | ||
| if (ts.isObjectLiteralExpression(node)) { | ||
| node.properties.forEach((prop) => { | ||
| if (ts.isPropertyAssignment(prop) && ts.isStringLiteral(prop.name)) { | ||
| const currentAddress = prop.name.getText().replace(/"/g, ""); | ||
|
|
||
| if (ts.isObjectLiteralExpression(prop.initializer)) { | ||
| const methodsProp = prop.initializer.properties.find( | ||
| (p) => ts.isPropertyAssignment(p) && ts.isIdentifier(p.name) && p.name.getText() === "methods", | ||
| ); | ||
|
|
||
| if (methodsProp && ts.isPropertyAssignment(methodsProp)) { | ||
| if (ts.isArrayLiteralExpression(methodsProp.initializer)) { | ||
| // Find methods that are not 'dojo_name', 'world_dispatcher', or 'create' | ||
| const interestingMethods = methodsProp.initializer.elements.filter( | ||
| (elem) => ts.isObjectLiteralExpression(elem) && hasInterestingEntrypoint(elem), | ||
| ); | ||
|
|
||
| interestingMethods.forEach((method) => { | ||
| const nameProperty = method.properties.find( | ||
| (p) => ts.isPropertyAssignment(p) && ts.isIdentifier(p.name) && p.name.getText() === "name", | ||
| ); | ||
|
|
||
| if (nameProperty) { | ||
| const systemName = nameProperty.initializer.getText().replace(/"/g, ""); | ||
| const newAddress = findAddressForSystem(systemName); | ||
|
|
||
| if (newAddress && newAddress !== currentAddress) { | ||
| console.log(`Updating address for system ${systemName}:`); | ||
| console.log(` Old address: ${currentAddress}`); | ||
| console.log(` New address: ${newAddress}`); | ||
|
|
||
| // Replace the old address with the new one | ||
| updatedContent = updatedContent.replace(`"${currentAddress}":`, `"${newAddress}":`); | ||
| } | ||
| } | ||
| }); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| ts.forEachChild(node, updateAddressesInPolicies); | ||
| } | ||
|
|
||
| function hasInterestingEntrypoint(methodNode) { | ||
| const nameProperty = methodNode.properties.find( | ||
| (p) => ts.isPropertyAssignment(p) && ts.isIdentifier(p.name) && p.name.getText() === "name", | ||
| ); | ||
|
|
||
| return ( | ||
| nameProperty && | ||
| ts.isStringLiteral(nameProperty.initializer) && | ||
| !["dojo_name", "world_dispatcher", "create"].includes(nameProperty.initializer.getText().replace(/"/g, "")) | ||
| ); | ||
| } | ||
|
|
||
| updateAddressesInPolicies(sourceFile); | ||
|
|
||
| writeFileSync(policiesPath, updatedContent); | ||
| console.log(`Policies file updated successfully for ${network} network.`); | ||
| } | ||
|
|
||
| // If run directly, default to sepolia | ||
| if (import.meta.url === `file://${process.argv[1]}`) { | ||
| const network = process.argv[2]; | ||
| updatePoliciesWithManifestAddresses(network, policiesPath); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Ensure safe replacement of addresses without unintended side effects
Using
updatedContent.replace(...)might unintentionally replace occurrences of the address elsewhere in the file. It's safer to modify the AST nodes directly to update the addresses without risking accidental replacements.Apply this diff to update the address using the TypeScript AST:
Alternatively, consider rewriting the logic to update the AST nodes directly and then regenerate the file content from the modified AST.
🧰 Tools
🪛 GitHub Actions: lint
[warning] Code formatting does not match Prettier standards. Run 'prettier --write' to fix formatting issues.