Adding ARM Support #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorbonas
reviewed
Nov 26, 2024
|
The This can be done by:
The documentation for the |
fredjoonpark
commented
Nov 28, 2024
| @@ -91,7 +91,7 @@ Resources: | |||
| - "logs:CreateLogStream" | |||
| - "logs:PutLogEvents" | |||
| Resource: | |||
| Fn::Sub: "arn:aws:logs:${AWS::Region}:${AWS::AccountId}:log-group:/aws/lambda/PrometheusTimestreamConnector-LambdaFunction-*:*" | |||
| Fn::Sub: "arn:aws:logs:${AWS::Region}:${AWS::AccountId}:log-group:/aws/lambda/${AWS::StackName}-LambdaFunction-*:*" | |||
There was a problem hiding this comment.
had to make this change for the log group to be created and see the logs
fredjoonpark
force-pushed
the
dev-arm-support
branch
from
87e9e13 to
8ae129d
Compare
trevorbonas
reviewed
Nov 28, 2024
trevorbonas
reviewed
Nov 28, 2024
|
verified I can use the OpenTelemetry collector to send data to timestream. Nice blog post @trevorbonas 💯 |
trevorbonas
approved these changes
Nov 29, 2024
forestmvey
approved these changes
Nov 29, 2024
fredjoonpark
added a commit
that referenced
this pull request
Dec 17, 2024
Adding ARM support to build script
fredjoonpark
added a commit
that referenced
this pull request
Jan 3, 2025
* Adding ARM Support (#10) Adding ARM support to build script * addressing ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arm64support to the build 💪samfor bothamd64andarm64architectures-can now be used safely in Timestream database/table namesI figured we'll do the version update with the other change we discussed earlier today, so I left it the same for now.