forked from awslabs/amazon-timestream-connector-prometheus
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SigV4 support #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorbonas
commented
Nov 15, 2024
trevorbonas
commented
Nov 15, 2024
trevorbonas
commented
Nov 15, 2024
forestmvey
reviewed
Nov 15, 2024
forestmvey
reviewed
Nov 15, 2024
forestmvey
reviewed
Nov 15, 2024
forestmvey
reviewed
Nov 15, 2024
forestmvey
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Connector:
enable_sigv4_auth
environment variable has been added. If this environment variable is true, basic auth headers will be ignored and the connector will attempt to use local credentials.SAM template:
EnableSigV4Auth
parameter has been added, which sets authentication toAWS_IAM
for the routes (/write
and/read
) and passes in theenable_sigv4_auth
environment variable to the connector Lambda function with the valuetrue
.APIGateway
resource has been changed to anAWS::ApiGatewayV2::Api
with protocol set toHTTP
. This was done because using API Gateway resources (such asAWS::ApiGatewayV2::Route
resources) on anAWS::Serverless::HttpApi
resource has undefined behaviour.Documentation:
Launch (SigV4)
links have been added to the DEVELOPER_README, which set theEnableSigV4Auth
parameter totrue
.Integration tests passed (
go test -v ./integration/
).Unit tests passed (
go test -tags=unit -cover -v ./timestream ./
).TLS tests passed (
go test -v ./integration/tls
).Correctness tests passed (
go test -v ./correctness
).Stack deployment tested with SigV4 enabled using the OpenTelemetry collector.
Stack deployment tested with SigV4 disabled using Prometheus for reading and writing.