Skip to content

Commit

Permalink
Spotless
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Carbonetto <[email protected]>
  • Loading branch information
acarbonetto committed Apr 1, 2024
1 parent 3df1021 commit a193266
Show file tree
Hide file tree
Showing 5 changed files with 64 additions and 66 deletions.
1 change: 0 additions & 1 deletion java/client/src/main/java/glide/api/BaseClient.java
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@
import glide.managers.CommandManager;
import glide.managers.ConnectionManager;
import java.util.List;
import glide.utils.ArrayTransformUtils;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.CompletableFuture;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@
import static redis_request.RedisRequestOuterClass.RequestType.Time;
import static redis_request.RedisRequestOuterClass.RequestType.Type;
import static redis_request.RedisRequestOuterClass.RequestType.Unlink;
import static redis_request.RedisRequestOuterClass.RequestType.ZScore;
import static redis_request.RedisRequestOuterClass.RequestType.XAdd;
import static redis_request.RedisRequestOuterClass.RequestType.ZScore;
import static redis_request.RedisRequestOuterClass.RequestType.Zadd;
import static redis_request.RedisRequestOuterClass.RequestType.Zcard;
import static redis_request.RedisRequestOuterClass.RequestType.Zrem;
Expand Down
37 changes: 18 additions & 19 deletions java/client/src/test/java/glide/api/RedisClientTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@
import static redis_request.RedisRequestOuterClass.RequestType.Time;
import static redis_request.RedisRequestOuterClass.RequestType.Type;
import static redis_request.RedisRequestOuterClass.RequestType.Unlink;
import static redis_request.RedisRequestOuterClass.RequestType.ZScore;
import static redis_request.RedisRequestOuterClass.RequestType.XAdd;
import static redis_request.RedisRequestOuterClass.RequestType.ZScore;
import static redis_request.RedisRequestOuterClass.RequestType.Zadd;
import static redis_request.RedisRequestOuterClass.RequestType.Zcard;
import static redis_request.RedisRequestOuterClass.RequestType.Zrem;
Expand Down Expand Up @@ -1827,7 +1827,6 @@ public void zscore_returns_success() {
assertEquals(value, payload);
}


@SneakyThrows
@Test
public void xadd_returns_success() {
Expand All @@ -1846,7 +1845,7 @@ public void xadd_returns_success() {

// match on protobuf request
when(commandManager.<String>submitNewCommand(eq(XAdd), eq(arguments), any()))
.thenReturn(testResponse);
.thenReturn(testResponse);

// exercise
CompletableFuture<String> response = service.xadd(key, fieldValues);
Expand All @@ -1866,21 +1865,21 @@ public void xadd_with_nomakestream_maxlen_options_returns_success() {
fieldValues.put("testField1", "testValue1");
fieldValues.put("testField2", "testValue2");
StreamAddOptions options =
StreamAddOptions.builder()
.id("id")
.makeStream(false)
.trim(new StreamAddOptions.Maxlen(true, 5L))
.build();
StreamAddOptions.builder()
.id("id")
.makeStream(false)
.trim(new StreamAddOptions.MaxLen(true, 5L))
.build();

String[] arguments =
new String[] {
key,
NO_MAKE_STREAM_REDIS_API,
TRIM_MAXLEN_REDIS_API,
TRIM_EXACT_REDIS_API,
Long.toString(5L),
"id"
};
new String[] {
key,
NO_MAKE_STREAM_REDIS_API,
TRIM_MAXLEN_REDIS_API,
TRIM_EXACT_REDIS_API,
Long.toString(5L),
"id"
};
arguments = ArrayUtils.addAll(arguments, convertMapToKeyValueStringArray(fieldValues));

String returnId = "testId";
Expand All @@ -1890,7 +1889,7 @@ public void xadd_with_nomakestream_maxlen_options_returns_success() {

// match on protobuf request
when(commandManager.<String>submitNewCommand(eq(XAdd), eq(arguments), any()))
.thenReturn(testResponse);
.thenReturn(testResponse);

// exercise
CompletableFuture<String> response = service.xadd(key, fieldValues, options);
Expand Down Expand Up @@ -1980,15 +1979,15 @@ public void xadd_with_options_returns_success(Pair<StreamAddOptions, String[]> o
fieldValues.put("testField1", "testValue1");
fieldValues.put("testField2", "testValue2");
String[] arguments =
ArrayUtils.addAll(optionAndArgs.getRight(), convertMapToKeyValueStringArray(fieldValues));
ArrayUtils.addAll(optionAndArgs.getRight(), convertMapToKeyValueStringArray(fieldValues));
String returnId = "testId";

CompletableFuture<String> testResponse = mock(CompletableFuture.class);
when(testResponse.get()).thenReturn(returnId);

// match on protobuf request
when(commandManager.<String>submitNewCommand(eq(XAdd), eq(arguments), any()))
.thenReturn(testResponse);
.thenReturn(testResponse);

// exercise
CompletableFuture<String> response = service.xadd(key, fieldValues, optionAndArgs.getLeft());
Expand Down
18 changes: 9 additions & 9 deletions java/client/src/test/java/glide/api/models/TransactionTests.java
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@
import static redis_request.RedisRequestOuterClass.RequestType.Time;
import static redis_request.RedisRequestOuterClass.RequestType.Type;
import static redis_request.RedisRequestOuterClass.RequestType.Unlink;
import static redis_request.RedisRequestOuterClass.RequestType.ZScore;
import static redis_request.RedisRequestOuterClass.RequestType.XAdd;
import static redis_request.RedisRequestOuterClass.RequestType.ZScore;
import static redis_request.RedisRequestOuterClass.RequestType.Zadd;
import static redis_request.RedisRequestOuterClass.RequestType.Zcard;
import static redis_request.RedisRequestOuterClass.RequestType.Zrem;
Expand Down Expand Up @@ -406,14 +406,14 @@ public void transaction_builds_protobuf_request(BaseTransaction<?> transaction)

transaction.xadd("key", Map.of("field1", "foo1"), StreamAddOptions.builder().id("id").build());
results.add(
Pair.of(
XAdd,
ArgsArray.newBuilder()
.addArgs("key")
.addArgs("id")
.addArgs("field1")
.addArgs("foo1")
.build()));
Pair.of(
XAdd,
ArgsArray.newBuilder()
.addArgs("key")
.addArgs("id")
.addArgs("field1")
.addArgs("foo1")
.build()));

transaction.time();
results.add(Pair.of(Time, ArgsArray.newBuilder().build()));
Expand Down
72 changes: 36 additions & 36 deletions java/integTest/src/test/java/glide/SharedCommandTests.java
Original file line number Diff line number Diff line change
Expand Up @@ -1143,33 +1143,33 @@ public void xadd(BaseClient client) {
String field2 = UUID.randomUUID().toString();

assertNull(
client
.xadd(
key,
Map.of(field1, "foo0", field2, "bar0"),
StreamAddOptions.builder().makeStream(Boolean.FALSE).build())
.get());
client
.xadd(
key,
Map.of(field1, "foo0", field2, "bar0"),
StreamAddOptions.builder().makeStream(Boolean.FALSE).build())
.get());

String timestamp1 = "0-1";
assertEquals(
timestamp1,
client
.xadd(
key,
Map.of(field1, "foo1", field2, "bar1"),
StreamAddOptions.builder().id(timestamp1).build())
.get());
timestamp1,
client
.xadd(
key,
Map.of(field1, "foo1", field2, "bar1"),
StreamAddOptions.builder().id(timestamp1).build())
.get());

assertNotNull(client.xadd(key, Map.of(field1, "foo2", field2, "bar2")).get());
if (client instanceof RedisClient) {
assertEquals(2L, ((RedisClient) client).customCommand(new String[] {"XLEN", key}).get());
} else if (client instanceof RedisClusterClient) {
assertEquals(
2L,
((RedisClusterClient) client)
.customCommand(new String[] {"XLEN", key})
.get()
.getSingleValue());
2L,
((RedisClusterClient) client)
.customCommand(new String[] {"XLEN", key})
.get()
.getSingleValue());
}

// this will trim the first entry.
Expand All @@ -1187,32 +1187,32 @@ public void xadd(BaseClient client) {
assertEquals(2L, ((RedisClient) client).customCommand(new String[] {"XLEN", key}).get());
} else if (client instanceof RedisClusterClient) {
assertEquals(
2L,
((RedisClusterClient) client)
.customCommand(new String[] {"XLEN", key})
.get()
.getSingleValue());
2L,
((RedisClusterClient) client)
.customCommand(new String[] {"XLEN", key})
.get()
.getSingleValue());
}

// this will trim the second entry.
assertNotNull(
client
.xadd(
key,
Map.of(field1, "foo4", field2, "bar4"),
StreamAddOptions.builder()
.trim(new StreamAddOptions.MinId(Boolean.TRUE, id))
.build())
.get());
client
.xadd(
key,
Map.of(field1, "foo4", field2, "bar4"),
StreamAddOptions.builder()
.trim(new StreamAddOptions.MinId(Boolean.TRUE, id))
.build())
.get());
if (client instanceof RedisClient) {
assertEquals(2L, ((RedisClient) client).customCommand(new String[] {"XLEN", key}).get());
} else if (client instanceof RedisClusterClient) {
assertEquals(
2L,
((RedisClusterClient) client)
.customCommand(new String[] {"XLEN", key})
.get()
.getSingleValue());
2L,
((RedisClusterClient) client)
.customCommand(new String[] {"XLEN", key})
.get()
.getSingleValue());
}

/**
Expand Down

0 comments on commit a193266

Please sign in to comment.