Split cluster and standalone jedis clients

Signed-off-by: Andrew Carbonetto <[email protected]>
Bit-Quill · Feb 15, 2024 · ab0b3b3 · ab0b3b3
1 parent 53c247f
commit ab0b3b3
Showing 1 changed file with 12 additions and 13 deletions.
diff --git a/java/benchmarks/src/main/java/glide/benchmarks/clients/jedis/JedisClient.java b/java/benchmarks/src/main/java/glide/benchmarks/clients/jedis/JedisClient.java
@@ -9,7 +9,6 @@
 import redis.clients.jedis.Jedis;
 import redis.clients.jedis.JedisCluster;
 import redis.clients.jedis.JedisPool;
-import redis.clients.jedis.util.JedisClusterCRC16;
 
 /** A Jedis client with sync capabilities. See: https://github.com/redis/jedis */
 public class JedisClient implements SyncClient {
@@ -28,14 +27,6 @@ public String getName() {
         return "Jedis";
     }
 
-    private Jedis getConnection(String key) {
-        if (isClusterMode) {
-            return new Jedis(jedisCluster.getConnectionFromSlot(JedisClusterCRC16.getSlot(key)));
-        } else {
-            return jedisPool.getResource();
-        }
-    }
-
     @Override
     public void connectToRedis(ConnectionSettings connectionSettings) {
         isClusterMode = connectionSettings.clusterMode;
@@ -51,15 +42,23 @@ public void connectToRedis(ConnectionSettings connectionSettings) {
 
     @Override
     public void set(String key, String value) {
-        try (Jedis jedis = getConnection(key)) {
-            jedis.set(key, value);
+        if (isClusterMode) {
+            jedisCluster.set(key, value);
+        } else {
+            try (Jedis jedis = jedisPool.getResource()) {
+                jedis.set(key, value);
+            }
         }
     }
 
     @Override
     public String get(String key) {
-        try (Jedis jedis = getConnection(key)) {
-            return jedis.get(key);
+        if (isClusterMode) {
+            return jedisCluster.get(key);
+        } else {
+            try (Jedis jedis = jedisPool.getResource()) {
+                return jedis.get(key);
+            }
         }
     }
 }