Rename in RequestType enum according to Feng-Shui.
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
requested review from
GumpacG,
aaron-congo,
acarbonetto,
tjzhang-BQ and
jhmannok
Signed-off-by: Yury-Fridlyand <[email protected]>
jonathanl-bq
approved these changes
May 4, 2024
|
|
||
| public class RedisClientTest { | ||
|
|
||
| // bypass import conflict between Set (collection) and Set (enum variant) | ||
| private static final RequestType pSet = RequestType.Set; |
There was a problem hiding this comment.
What does the "p" in "pSet" stand for?
There was a problem hiding this comment.
protobuf
I agree it is bad naming
acarbonetto
approved these changes
May 6, 2024
Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
merged commit 61f1e2c
into
core/integ_yuryf_rename_in_proto
44 checks passed
Yury-Fridlyand
added a commit
that referenced
this pull request
May 10, 2024
…o#1387) * Rename in `RequestType` enum according to Feng-Shui. (#262) Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>
cyip10
pushed a commit
that referenced
this pull request
Jun 24, 2024
…o#1387) * Rename in `RequestType` enum according to Feng-Shui. (#262) Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from #220
HvalstoHValsHashDeltoHDel{G,S}etStringrenamed to{G,S}etAll renames (except
HashSet) were done withCtrl+Shift+Hmagic