Java: README.md #388

cyip10 · 2024-06-25T00:01:43Z

* Python: Added COPY command (#383) Python: Added COPY command * Updated CHANGELOG.md * Addressed review comments

* Java: Add `SORT` and `SORT_RO` commands (#363) Co-authored-by: Yury-Fridlyand <[email protected]>

* Python: add XREVRANGE command * Update doc for xrevrange Signed-off-by: Andrew Carbonetto <[email protected]> * Update transaction docs Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]>

* Java: Add `FUNCTION DUMP` and `FUNCTION RESTORE`. (#370) * Add `FUNCTION DUMP` and `FUNCTION RESTORE` implementations. Signed-off-by: Yury-Fridlyand <[email protected]> * Address PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> * Add tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Address PR comments. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> * Use GlideString Signed-off-by: Andrew Carbonetto <[email protected]> * Clean up FUNCTION DUMP & RESTORE Signed-off-by: Andrew Carbonetto <[email protected]> * Update handlers Signed-off-by: Andrew Carbonetto <[email protected]> * Update comments Signed-off-by: Andrew Carbonetto <[email protected]> * Add cluster IT test Signed-off-by: Andrew Carbonetto <[email protected]> * quick review comment Signed-off-by: Andrew Carbonetto <[email protected]> * SPOTLESS Signed-off-by: Andrew Carbonetto <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Andrew Carbonetto <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]>

…ey-io#1629)

support bitcount with GlideString

support bitop, bitpos and xdel with GlideString

valkey-io#1630) support hincrby, hincrbyfloat, incrby and incrbyfloat with GlideString

support llen, strlen, xlen and hstrlen with GlideString

…ey-io#1633)

valkey-io#1634) support zintercard, zdiffstore, zremrangebyrank, lpush, lpushx, lrem, rpus and rpushx with GlideString

* Python: add XREAD command * Minor doc fix * PR suggestions

java/README.md

Yury-Fridlyand · 2024-06-25T21:56:36Z

java/README.md

 **Dependencies installation for Ubuntu**
+


A user of java wrapper don't need rust, gcc, git and other things. Only java and maybe openssl.
Protobuf is also not needed for the client user.

Exactly. Java users should only need to import the JAR library as a dependency from Maven or Gradle - or download. Building from source should be part of the DEVELOPER.md. You could reference the DEVELOPER.md if you want to point them to how to build from source.

Yury-Fridlyand · 2024-06-25T21:57:23Z

java/README.md

- OpenJDK 64-Bit Server VM 18.9 (build 11.0.1+13, mixed mode)
+```bash
+echo $JAVA_HOME
+java -version
 ```

 #### Building and installation steps


This should be in developer.md. I think you already added all what we need, so delete this section in this file.

I think we should keep this to make sure they are running it on jdk11

Good point. So keep that block (java version check) and jdk installation. All the rest installation could be removed.

java/README.md

Yury-Fridlyand · 2024-06-25T22:00:29Z

java/README.md

+assert setResponse.get() == "OK" : "Failed on client.set("key", "foobar") request";
+
+CompletableFuture<String> getResponse = client.get("key");
+assert getResponse.get() == "foobar" : "Failed on client.get("key") request";


Suggested change

assert setResponse.get() == "OK" : "Failed on client.set("key", "foobar") request";

CompletableFuture<String> getResponse = client.get("key");

assert getResponse.get() == "foobar" : "Failed on client.get("key") request";

assert setResponse.get() == "OK" : "Failed on client.set(\"key\", \"foobar\") request";

CompletableFuture<String> getResponse = client.get("key");

assert getResponse.get() == "foobar" : "Failed on client.get(\"key\") request";

Maybe use GlideString? APIs with String to be removed soon.

Yury-Fridlyand · 2024-06-26T23:15:06Z

java/README.md

+
+Maven (AARCH_64) specific.
+- **IMPORTANT** must include a `classifier` block. Please use this dependency block instead and add it to the pom.xml file.
+```bash


Suggested change

```bash

```xml

Yury-Fridlyand · 2024-06-26T23:15:43Z

java/README.md


 ```java
-import glide.api.RedisClient;
+import glide.api.ValkeyClient;


Suggested change

import glide.api.ValkeyClient;

import glide.api.GlideClient;

Update below too

Yury-Fridlyand · 2024-06-26T23:18:05Z

java/README.md

+- Copy the snippet and paste it in the `build.gradle` dependencies section.
+
+Maven (AARCH_64) specific.
+- **IMPORTANT** must include a `classifier` block. Please use this dependency block instead and add it to the pom.xml file.


Shouldn't we include classifier for mac x64 or linux x64?

Yury-Fridlyand · 2024-06-26T23:18:30Z

java/README.md

+Gradle:
+- Copy the snippet and paste it in the `build.gradle` dependencies section.
+
+Maven (AARCH_64) specific.


Please also add example in gradle syntax.

something to copy-paste ;)

acarbonetto · 2024-06-27T16:55:59Z

CHANGELOG.md

@@ -49,6 +49,9 @@
 * Python: Added ZREVRANK command ([#1614](https://github.com/aws/glide-for-redis/pull/1614))
 * Python: Added XDEL command ([#1619](https://github.com/aws/glide-for-redis/pull/1619))
 * Python: Added XRANGE command ([#1624](https://github.com/aws/glide-for-redis/pull/1624))
+* Python: Added COPY command ([#1626](https://github.com/aws/glide-for-redis/pull/1626))
+* Python: Added XREVRANGE command ([#1625](https://github.com/aws/glide-for-redis/pull/1625))
+* Python: Added XREAD command ([#1644](https://github.com/aws/glide-for-redis/pull/1644))


rebase please...

java/README.md

acarbonetto · 2024-06-27T16:59:31Z

java/README.md

 **Dependencies installation for Ubuntu**
+


Exactly. Java users should only need to import the JAR library as a dependency from Maven or Gradle - or download. Building from source should be part of the DEVELOPER.md. You could reference the DEVELOPER.md if you want to point them to how to build from source.

acarbonetto · 2024-06-27T16:59:46Z

java/README.md

+Gradle:
+- Copy the snippet and paste it in the `build.gradle` dependencies section.
+
+Maven (AARCH_64) specific.


something to copy-paste ;)

Yury-Fridlyand · 2024-06-27T21:50:08Z

Supereded by #395

yipin-chen and others added 12 commits June 21, 2024 17:31

Python: add COPY Command (valkey-io#1626)

7e32e1b

* Python: Added COPY command (#383) Python: Added COPY command * Updated CHANGELOG.md * Addressed review comments

Java: Add SORT and SORT_RO commands (valkey-io#1611)

2438d8b

* Java: Add `SORT` and `SORT_RO` commands (#363) Co-authored-by: Yury-Fridlyand <[email protected]>

Added support for append + smembers (GlideString version) (valk…

93b0f02

…ey-io#1629)

support bitcount with GlideString (valkey-io#1627)

8f03ac9

support bitcount with GlideString

support bitop, bitpos and xdel with GlideString (valkey-io#1628)

62da7f8

support bitop, bitpos and xdel with GlideString

support hincrby, hincrbyfloat, incrby and incrbyfloat with GlideString (

6242abb

valkey-io#1630) support hincrby, hincrbyfloat, incrby and incrbyfloat with GlideString

support llen, strlen, xlen and hstrlen with GlideString (valkey-io#1632)

a41887a

support llen, strlen, xlen and hstrlen with GlideString

support zincrby, zrem, zrank, zscore and zcard with GlideString (valk…

d6595bf

…ey-io#1633)

support zintercard, zdiffstore, zremrangebyrank, lpush, lpushx, lrem,… (

66d97e5

valkey-io#1634) support zintercard, zdiffstore, zremrangebyrank, lpush, lpushx, lrem, rpus and rpushx with GlideString

Python: add XREAD command (valkey-io#1644)

a8e7f77

* Python: add XREAD command * Minor doc fix * PR suggestions

Elen-Ghulam reviewed Jun 25, 2024

View reviewed changes

java/README.md Show resolved Hide resolved

Yury-Fridlyand reviewed Jun 25, 2024

View reviewed changes

Yury-Fridlyand reviewed Jun 26, 2024

View reviewed changes

cyip10 added 5 commits June 26, 2024 19:33

implement readme

b2ece6c

add supported OS section

7ffa464

add set up information

855999e

current progress

268cda4

fix examples

a35414e

cyip10 force-pushed the java/dev_cyip10_readme branch from f9c42eb to a35414e Compare June 27, 2024 04:17

cyip10 mentioned this pull request Jun 27, 2024

Java: new README.md #395

Merged

acarbonetto approved these changes Jun 27, 2024

View reviewed changes

Yury-Fridlyand closed this Jun 27, 2024

Yury-Fridlyand deleted the java/dev_cyip10_readme branch June 27, 2024 21:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Java: README.md #388

Java: README.md #388

cyip10 commented Jun 25, 2024

Yury-Fridlyand Jun 25, 2024 •

edited

Loading

acarbonetto Jun 27, 2024

Yury-Fridlyand Jun 25, 2024

cyip10 Jun 26, 2024

Yury-Fridlyand Jun 26, 2024

Yury-Fridlyand Jun 25, 2024

Yury-Fridlyand Jun 25, 2024

Yury-Fridlyand Jun 26, 2024

Yury-Fridlyand Jun 26, 2024

Yury-Fridlyand Jun 26, 2024

Yury-Fridlyand Jun 26, 2024

acarbonetto Jun 27, 2024

acarbonetto Jun 27, 2024

acarbonetto Jun 27, 2024

acarbonetto Jun 27, 2024

Yury-Fridlyand commented Jun 27, 2024

Java: README.md #388

Java: README.md #388

Conversation

cyip10 commented Jun 25, 2024

Yury-Fridlyand Jun 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yury-Fridlyand commented Jun 27, 2024

Yury-Fridlyand Jun 25, 2024 •

edited

Loading