Node: Add binary variant to PUBSUB NUMSUB and PUBSUB SHARDNUMSUB
#419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
|
@Yury-Fridlyand: for these 2 commands, I am not sure how to verify binary in the test. Any suggestion? |
Signed-off-by: Yi-Pin Chen <[email protected]>
Yury-Fridlyand
approved these changes
Aug 29, 2024
Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
Signed-off-by: Yi-Pin Chen <[email protected]>
yipin-chen
merged commit ff46c1f
into
node/integ-valkey-293-return-record-with-glidestring
4 of 8 checks passed
jonathanl-bq
pushed a commit
that referenced
this pull request
Sep 10, 2024
…lkey-io#2207) * returning a record replacement with glide strings. * Node: Add binary variant to `PUBSUB NUMSUB` and `PUBSUB SHARDNUMSUB` (#419) * Updated PubSub shardnumsub and numsub commands * Fix tests. * Add binary variant to PUBSUB subscribe commands * Fix processing cluster response. Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: Yi-Pin Chen <[email protected]> Co-authored-by: Andrew Carbonetto <[email protected]> Co-authored-by: Yi-Pin Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.