-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IT framework #63
Add IT framework #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you planning to add an IT test to show it working?
On next PR or after rebasing on base commands PR + cluster client PR. |
645d280
to
9cdd788
Compare
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
dff58f6
to
f6f425e
Compare
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Note: Python and Node CI fails on |
Signed-off-by: Yury-Fridlyand <[email protected]>
Small note on the PR description, it mentions the cluster is available on ports 7000-7006 but in the PR it looks like the cluster is on ports 7000-7005. The example command to start the redis cluster in the PR description also looks like it starts it on 8000-8005 so it should probably be updated to use 7000-7005 |
Sharp eyes! Command line listed in PR is an example. It could be helpful for test R&D. |
* Add IT framework (#63) Signed-off-by: Yury-Fridlyand <[email protected]>
Based on #54/valkey-io#796
This starts redis in standalone mode on port 6380 in CI and a cluster on ports 7000-7006.
To connect to standalone use:
To connect to cluster use:
NOTE don't use
Future::get
without specifying a timeout, because it hangs IT/CI on an error!Test can be started by
The test report is written to
Redis server logs are stored in
until next test start
To start redis standalone instance IT uses
To start redis cluster
To stop all