Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_info read initialized byte from HWW_INFO req #82

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

NicolaLS
Copy link
Contributor

Read the initialized byte returned after firmware version 9.20.0 and add it to the Info struct.

since firmware PR 1229 is merged.

@NicolaLS NicolaLS force-pushed the device-info-initialized branch 2 times, most recently from 9d9465f to 3c43bc7 Compare July 30, 2024 15:09
Copy link
Contributor

@benma benma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

NPM_VERSION Outdated
0.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPM package didn't change, so revert this please

Cargo.toml Outdated
@@ -1,7 +1,7 @@
[package]
name = "bitbox-api"
authors = ["Marko Bencun <[email protected]>"]
version = "0.4.1"
version = "0.5.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API of this library didn't change, so revert this please

@NicolaLS NicolaLS force-pushed the device-info-initialized branch from 3c43bc7 to 4cc6f8c Compare August 1, 2024 18:26
Read the initialized byte returned after firmware version 9.20.0 and add
it to the Info struct.
@NicolaLS NicolaLS force-pushed the device-info-initialized branch from 4cc6f8c to f0fcf61 Compare August 1, 2024 18:29
@NicolaLS NicolaLS requested a review from benma August 1, 2024 18:31
@benma benma merged commit 23de208 into BitBoxSwiss:master Aug 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants