We should avoid setting GO env variables#3231
Conversation
NickeZ
force-pushed
the
nickez/remove-gopath
branch
from
f2cbde6 to
90f1960
Compare
|
|
||
| SHELL := /bin/bash | ||
| WEBROOT := frontends/web | ||
| GOPATH ?= $(HOME)/go |
There was a problem hiding this comment.
GOPATH can be any directory on your system. In Unix examples, we will set it to $HOME/go (the default since Go 1.8).
NickeZ
force-pushed
the
nickez/remove-gopath
branch
4 times, most recently
from
034ef51 to
e90f28d
Compare
|
Ready for review, need help publishing container tag |
NickeZ
force-pushed
the
nickez/remove-gopath
branch
5 times, most recently
from
a0155e4 to
c6fd07e
Compare
It should be enough to temporarily set GOPATH during docker image build to install tools in a shared directory and then add that directory to $PATH. The defaults on linux are: GOPATH = ~/go GOROOT = /usr/local/go GOMODCACHE = GOPATH[0]/pkg/mod
NickeZ
force-pushed
the
nickez/remove-gopath
branch
from
c6fd07e to
c3c44ae
Compare
| popd | ||
| export PATH="~/go/bin:$PATH" | ||
| mkdir -p $(go env GOPATH)/$(dirname $GO_SRC_DIR) | ||
| cp -a ../bitbox-wallet-app $(go env GOPATH)/$(dirname $GO_SRC_DIR) |
There was a problem hiding this comment.
this seems wrong, there should be no need to copy the repo somewhere else.
There was a problem hiding this comment.
Is that something from how go used to work? that the go code had to be copied to a certain directory structure?
There was a problem hiding this comment.
There is this comment earlier:
# Because we need to compile some Go code without modules,
# the source must be placed in a specific directory as expected by Go.
# The path is relative to GOPATH.
GO_SRC_DIR=src/github.com/BitBoxSwiss/bitbox-wallet-app
There was a problem hiding this comment.
Since Go modules has been introduced, the repo can live anywhere. There is, or was, a catch with gomobile, which isn't compatible with modules:
- x/mobile: does not work with Go 1.22 if a vendor folder is present, even with the
GO111MODULE=offworkaround golang/go#67927 - x/mobile: gomobile bind does not support vendor golang/go#34181
This forced us to turn off modules, which required the repo to be again in the GOPATH like it was required in the past.
However, GO111MODULE=off was removed in this commit 684e62e#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L31, so maybe even android/iOS can now be built regardless of the location, but I am not sure.
I guess for this PR, you could just leave it as is, as changing this is unrelated to this PR.
2 participants
It should be enough to temporarily set GOPATH during docker image build to install tools in a shared directory and then add that directory to $PATH.
The defaults on unix are:
GOPATH = ~/go
GOROOT = /usr/local/go
GOMODCACHE = GOPATH[0]/pkg/mod
I will have to test this myself first when I have better internet and can use docker.