frontend: use mobile header for back navigation on mobile#4197
Merged
Conversation
thisconnect
requested changes
Jun 22, 2026
| title={ | ||
| status === 'connect' ? ( | ||
| <MobileHeader | ||
| variant={loading ? 'titleOnly' : 'back'} |
Collaborator
There was a problem hiding this comment.
The "loading" state confused me quickly, it is not about loading the UI but gets set to true when doing a new connection while pairing.
tested on Android 👍
shonsirsha
force-pushed
the
frontend-back-chevron
branch
from
6df31da to
7328cf1
Compare
Collaborator
Author
|
@thisconnect , thanks a lot for the reviews! PTAL 🙏 |
shonsirsha
force-pushed
the
frontend-back-chevron
branch
2 times, most recently
from
3a0f7fb to
473c147
Compare
thisconnect
approved these changes
Jul 2, 2026
| fullscreen | ||
| onClose={isMobile ? undefined : handleClose} | ||
| verticallyCentered> | ||
| {mobileHeader()} |
Collaborator
There was a problem hiding this comment.
nit:
Suggested change
| {mobileHeader()} | |
| <MobileHeader | |
| title={t('deviceSettings.expert.bip85.title')} | |
| withViewPadding | |
| /> |
| fullscreen | ||
| onClose={isMobile ? undefined : handleClose} | ||
| verticallyCentered> | ||
| {mobileHeader(() => setStatus('info-what'))} |
Collaborator
There was a problem hiding this comment.
nit: simpler and less mental overhead here and all the other places below
Suggested change
| {mobileHeader(() => setStatus('info-what'))} | |
| <MobileHeader | |
| onClick={() => setStatus('info-what')} | |
| title={t('deviceSettings.expert.bip85.title')} | |
| withViewPadding | |
| /> |
changed the previously used Back button on page body, to be the chevron back on mobile header.
shonsirsha
force-pushed
the
frontend-back-chevron
branch
from
473c147 to
cb9a004
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chevron Back On Mobile
SendReceiveAddAccountConnectScreenWalletConnect/WCConnectFormElectrumSettings(Connect full node)SwapManageBackups/BackupsListSDCardCheckcovered by surroundingManageBackupsheaderRecoveryWordsBip85Passphrase/EnableInfo/DisableInfoSetupOptionsadvanced screenSetDeviceNameSetDeviceNameWithSDCardviaSetDeviceNameRestoreFromSDCardBackuptitleOnly Usage
MobileHeadergets the newvariant="titleOnly"support.ConnectScreenWalletConnectuses it while WalletConnect is loading:variant={loading ? 'titleOnly' : 'back'}. This shows the mobile title without a chevron during connect/pairing loading.