bootloader: improve exec function #1333
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some comments about what every assembly line does. Mark which c-variables are used and which registers are used so that GCC doesn't do the wrong optimizations.
I think we are a bit naive when we read
r0
, expecting the value ofl_code_addr
to be there. According to the ARM calling convention, the first argument should be there. But since we don't even have "noinline", this whole function could be inlined. And the compiler is free to move around ASM blocks (with some constraints) as noted in the quote below.References:
Re "Basic ASM" (that we use today)
Considerations