-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIBUTING.md added #13
Conversation
@garg3133 tried adding this line to Wants to add new repo in the list checkout CONTRIBUTING.md for the samebut i doubt this would be picked up by python file as i have added it in end. |
@priyanshnama How about splitting the template into two files? |
CONTRIBUTING.md
Outdated
|
||
## Getting Started | ||
|
||
1. Submit an issue describing your proposed change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if they are adding a new repo to this list, opening an issue won't make sense.
They should only open issues if they are proposing something new. So, we can make a new section for this something like Want to propose something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually i added that in general sense, if any person encounters any flaws or wants a feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it sounds more like they need to open an issue everytime they want to add something, even while adding a new repository.
Feel free to open an issue if you have something new to propose or something similar will sound better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes... this should be done.. i am pushing a commit for the same
CONTRIBUTING.md
Outdated
|
||
## Making Changes | ||
|
||
* Create a branch : `git checkout -b branch-name`. Please avoidmworking directly on the `master` branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, fix the typo here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for this typo, i shall fix this
@garg3133 then why to create a new file |
@priyanshnama And how about deprecating the use of |
Also, I'm thinking of putting repositories in Categories. Any idea how should we make those categories? Like difficulty-wise or language-wise.. |
@garg3133 i don't think we should do that.I fear it would increase cognitive complexity of python code. |
@garg3133 yup. we can do this. |
I have added CONTRIBUTING.md file to help people in sending pull request and contribute to this.
#3
Do Suggest changes if any.