Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md added #13

Merged
merged 3 commits into from
Oct 8, 2020
Merged

Conversation

priyanshnama
Copy link
Member

I have added CONTRIBUTING.md file to help people in sending pull request and contribute to this.
#3
Do Suggest changes if any.

@priyanshnama
Copy link
Member Author

@garg3133 tried adding this line to template.md

Wants to add new repo in the list checkout CONTRIBUTING.md for the same

but i doubt this would be picked up by python file as i have added it in end.
I have not included this change in the pr as of now.

@garg3133
Copy link
Member

garg3133 commented Oct 8, 2020

@priyanshnama How about splitting the template into two files? template-top.md and template-bottom.md.

CONTRIBUTING.md Outdated

## Getting Started

1. Submit an issue describing your proposed change.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if they are adding a new repo to this list, opening an issue won't make sense.

They should only open issues if they are proposing something new. So, we can make a new section for this something like Want to propose something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually i added that in general sense, if any person encounters any flaws or wants a feature.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it sounds more like they need to open an issue everytime they want to add something, even while adding a new repository.

Feel free to open an issue if you have something new to propose or something similar will sound better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes... this should be done.. i am pushing a commit for the same

CONTRIBUTING.md Outdated

## Making Changes

* Create a branch : `git checkout -b branch-name`. Please avoidmworking directly on the `master` branch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, fix the typo here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for this typo, i shall fix this

@priyanshnama
Copy link
Member Author

@priyanshnama How about splitting the template into two files? template-top.md and template-bottom.md.

@garg3133 then why to create a new file template-bottom.md
we can hardcode the markdown text in python file as a string and use it - as it is just one line of code.
because we will have to bring changes in python file in both ways.

@garg3133
Copy link
Member

garg3133 commented Oct 8, 2020

@priyanshnama And how about deprecating the use of template.md also and bringing all the content from json file itself?

@garg3133
Copy link
Member

garg3133 commented Oct 8, 2020

Also, I'm thinking of putting repositories in Categories. Any idea how should we make those categories? Like difficulty-wise or language-wise..

@priyanshnama
Copy link
Member Author

@priyanshnama And how about deprecating the use of template.md also and bringing all the content from json file itself?

@garg3133 i don't think we should do that.

I fear it would increase cognitive complexity of python code.
Moreover, a sperate file makes us understand how the structure of readme would be - using only python code won't.
The functionality of python code is really understandable as of now.
Moreover, making any change in structure of readme would be very easy till we use template.md

@priyanshnama
Copy link
Member Author

Also, I'm thinking of putting repositories in Categories. Any idea how should we make those categories? Like difficulty-wise or language-wise..

@garg3133 yup. we can do this.
I think we should do this language wise.

@priyanshnama priyanshnama requested a review from garg3133 October 8, 2020 14:38
@garg3133 garg3133 merged commit a5e9d5d into BitByte-TPC:master Oct 8, 2020
@priyanshnama priyanshnama deleted the contributing.md branch October 8, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants