Skip to content

Commit

Permalink
chore(sdk-core): fix unknown types of sinon spy getCalls
Browse files Browse the repository at this point in the history 
TICKET: WP-00000
  • Loading branch information
@pranavjain97
pranavjain97 committed Dec 1, 2024
1 parent 1a57a84 commit abbb3b8
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 16 deletions.
4 changes: 2 additions & 2 deletions modules/bitgo/test/v2/unit/internal/tssUtils/ecdsa.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -910,7 +910,7 @@ describe('TSS Ecdsa Utils:', async function () {
reqId,
});
signedTxRequest.unsignedTxs.should.deepEqual(txRequest.unsignedTxs);
const userGpgActual = sendShareSpy.getCalls()[0].args[10];
const userGpgActual = sendShareSpy.getCalls()[0].args[10] as string;
userGpgActual.should.startWith('-----BEGIN PGP PUBLIC KEY BLOCK-----');
});

Expand All @@ -927,7 +927,7 @@ describe('TSS Ecdsa Utils:', async function () {
reqId,
});
signedTxRequest.unsignedTxs.should.deepEqual(txRequest.unsignedTxs);
const userGpgActual = sendShareSpy.getCalls()[0].args[10];
const userGpgActual = sendShareSpy.getCalls()[0].args[10] as string;
userGpgActual.should.startWith('-----BEGIN PGP PUBLIC KEY BLOCK-----');
});

Expand Down
30 changes: 16 additions & 14 deletions modules/bitgo/test/v2/unit/wallet.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ import {
SendManyOptions,
PopulatedIntent,
TxRequestVersion,
WalletSignMessageOptions,
WalletSignTypedDataOptions,
} from '@bitgo/sdk-core';

import { TestBitGo } from '@bitgo/sdk-test';
Expand Down Expand Up @@ -3334,8 +3336,8 @@ describe('V2 Wallet:', function () {
prv: 'secretKey',
});
signMessage.should.deepEqual(expectedWithCoinField);
const actualArg = signMessageTssSpy.getCalls()[0].args[0];
actualArg.message.messageEncoded.should.equal(
const actualArg = signMessageTssSpy.getCalls()[0].args[0] as WalletSignMessageOptions;
actualArg.message?.messageEncoded?.should.equal(
`\u0019Ethereum Signed Message:\n${messageRaw.length}${messageRaw}`
);
});
Expand All @@ -3351,8 +3353,8 @@ describe('V2 Wallet:', function () {
prv: 'secretKey',
});
signMessage.should.deepEqual(expectedWithCoinField);
const actualArg = signMessageTssSpy.getCalls()[0].args[0];
actualArg.message.messageEncoded.should.equal(
const actualArg = signMessageTssSpy.getCalls()[0].args[0] as WalletSignMessageOptions;
actualArg.message?.messageEncoded?.should.equal(
`\u0019Ethereum Signed Message:\n${messageRaw.length}${messageRaw}`
);
});
Expand All @@ -3367,8 +3369,8 @@ describe('V2 Wallet:', function () {
prv: 'secretKey',
});
signMessage.should.deepEqual(expectedWithCoinField);
const actualArg = signMessageTssSpy.getCalls()[0].args[0];
actualArg.message.messageEncoded.should.equal(
const actualArg = signMessageTssSpy.getCalls()[0].args[0] as WalletSignMessageOptions;
actualArg.message?.messageEncoded?.should.equal(
`\u0019Ethereum Signed Message:\n${messageRaw.length}${messageRaw}`
);
});
Expand Down Expand Up @@ -3530,8 +3532,8 @@ describe('V2 Wallet:', function () {
prv: 'secretKey',
});
signedTypedData.should.deepEqual(expected);
const actualArg = signTypedDataTssSpy.getCalls()[0].args[0];
actualArg.typedData.typedDataEncoded.toString('hex').should.equal(txHash);
const actualArg = signTypedDataTssSpy.getCalls()[0].args[0] as WalletSignTypedDataOptions;
actualArg.typedData?.typedDataEncoded?.toString('hex').should.equal(txHash);
});

it('should sign typed data V3 when custodianMessageID is provided', async function () {
Expand All @@ -3552,8 +3554,8 @@ describe('V2 Wallet:', function () {
prv: 'secretKey',
});
signedTypedData.should.deepEqual(expected);
const actualArg = signTypedDataTssSpy.getCalls()[0].args[0];
actualArg.typedData.typedDataEncoded.toString('hex').should.equal(txHash);
const actualArg = signTypedDataTssSpy.getCalls()[0].args[0] as WalletSignTypedDataOptions;
actualArg.typedData?.typedDataEncoded?.toString('hex').should.equal(txHash);
});

it('should fail to sign typed data V3 with empty prv', async function () {
Expand All @@ -3577,8 +3579,8 @@ describe('V2 Wallet:', function () {
prv: 'secretKey',
});
signedTypedData.should.deepEqual(expected);
const actualArg = signedTypedDataTssSpy.getCalls()[0].args[0];
actualArg.typedData.typedDataEncoded.toString('hex').should.equal(txHash);
const actualArg = signedTypedDataTssSpy.getCalls()[0].args[0] as WalletSignTypedDataOptions;
actualArg.typedData?.typedDataEncoded?.toString('hex').should.equal(txHash);
});
});

Expand Down Expand Up @@ -3643,8 +3645,8 @@ describe('V2 Wallet:', function () {
prv: 'secretKey',
});
signedTypedData.should.deepEqual(expected);
const actualArg = signedTypedDataTssSpy.getCalls()[0].args[0];
actualArg.typedData.typedDataEncoded.toString('hex').should.equal(txHash);
const actualArg = signedTypedDataTssSpy.getCalls()[0].args[0] as WalletSignTypedDataOptions;
actualArg.typedData?.typedDataEncoded?.toString('hex').should.equal(txHash);
});
});
});
Expand Down

0 comments on commit abbb3b8

Please sign in to comment.