chore: update imports for node 24

[mhahn2003]

This is done for Node.js 24 compatibility

• Replace import assert = require('assert') with import assert from 'assert' to resolve "TypeScript import equals declaration is not supported in strip-only mode" error

• Use type-only imports to resolve ESM issues

• Replace const ... = require('') to import statements

• Move type classifiers out of constructors

TICKET: CAAS-325

[andrew-scott-fischer]

As a separate item to action, we should probably move from assert to assert/strict. see here

[prabh-codes]

Less effective, often pulls in more code than necessary.

import { BaseMessage, BaseMessageBuilder, BaseMessageBuilderFactory, IMessage, IMessageBuilder, MessageOptions, MessageStandardType, } from '@bitgo/sdk-core'; was good. While you can import type separately for readability but importing by first approach is still considered as good due to:

1. Optimal Tree Shaking
2. Clear Intent
3. Simplicity

[mhahn2003]

@prabh-codes This was done more so to resolve this type of error rather than readability:

@bitgo/abstract-eth: file:///Users/michaelhahn/bitgo/BitGoJS/modules/abstract-eth/test/unit/token.ts:1
@bitgo/abstract-eth: import { TestBitGo, TestBitGoAPI } from '@bitgo/sdk-test';
@bitgo/abstract-eth: ^^^^^^^^^^^^
@bitgo/abstract-eth: SyntaxError: Named export 'TestBitGoAPI' not found. The requested module '@bitgo/sdk-test' is a CommonJS module, which may not support all module.exports as named exports.
@bitgo/abstract-eth: CommonJS modules can always be imported via the default export, for example using:
@bitgo/abstract-eth: import pkg from '@bitgo/sdk-test';
@bitgo/abstract-eth: const { TestBitGo, TestBitGoAPI } = pkg;
@bitgo/abstract-eth: at ModuleJob.#_instantiate (node:internal/modules/esm/module_job:254:21)
@bitgo/abstract-eth: at async ModuleJob.run (node:internal/modules/esm/module_job:362:5)
@bitgo/abstract-eth: at async onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:665:26)
@bitgo/abstract-eth: at async formattedImport (/Users/michaelhahn/bitgo/BitGoJS/node_modules/mocha/lib/nodejs/esm-utils.js:7:14)
@bitgo/abstract-eth: at async Object.exports.requireOrImport (/Users/michaelhahn/bitgo/BitGoJS/node_modules/mocha/lib/nodejs/esm-utils.js:48:32)
@bitgo/abstract-eth: at async Object.exports.loadFilesAsync (/Users/michaelhahn/bitgo/BitGoJS/node_modules/mocha/lib/nodejs/esm-utils.js:103:20)
@bitgo/abstract-eth: at async singleRun (/Users/michaelhahn/bitgo/BitGoJS/node_modules/mocha/lib/cli/run-helpers.js:125:3)
@bitgo/abstract-eth: at async Object.exports.handler (/Users/michaelhahn/bitgo/BitGoJS/node_modules/mocha/lib/cli/run.js:374:5)
@bitgo/abstract-eth: error Command failed with exit code 1.
@bitgo/abstract-eth: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[andrew-scott-fischer]

The error you post is related to @bitgo/sdk-test, not @bitgo/sdk-core. Regardless, @prabh-codes is correct. You should go fix this in the module you are importing from, rather than just importing everything with a * wild card.