Don't rely on ECC lib for curve/point check #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move the (much simplified) type check function to types.ts * Use `Tapleaf` type a bit more (this might be a bad idea) * Be more consistent in the capitalization of `Taptree`
Because the taggedHash API is typed, these are compile-time checked and it's more clear w/o the constants.
* More clearly show the continuation and base cases in findScriptPath * Return undefined not empty path when no path is found * This would lead to generating an invalid witness * Tighten the type for HashTree to not allow 1-sided branch nodes
* Also added caching of `hashTree`, per todo. * Added a test for this functionality
The spec uses this notation because in a spec there's no such thing as reassigning a value. In real code it is appropriate to us accumulators or such.
brandonblack
force-pushed
the
unthread_ecc
branch
3 times, most recently
from
95eeb4a to
c23f19f
Compare
* Add basic isXOnlyPoint check to types. * Use basic isXOnlyPoint check in p2tr * Only use ECC lib for tweaking in p2tr * Remove ECC lib from PSBT * tweaking is done by provided `finalizeScriptsFunc` * Update test vectors to reflect these changes
brandonblack
force-pushed
the
unthread_ecc
branch
from
c23f19f to
0bd4a45
Compare
brandonblack
force-pushed
the
unthread_ecc
branch
from
0bd4a45 to
08f2672
Compare
brandonblack
force-pushed
the
unthread_ecc
branch
from
08f2672 to
78b20db
Compare
brandonblack
referenced
this pull request
Mar 23, 2022
brandonblack
force-pushed
the
p2tr-v1
branch
6 times, most recently
from
79d14a7 to
d8ddfae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.