Skip to content

fix: e2e capacity#94

Merged
kasin-it merged 1 commit into
mainfrom
dev
Jun 18, 2026
Merged

fix: e2e capacity#94
kasin-it merged 1 commit into
mainfrom
dev

Conversation

@kasin-it

@kasin-it kasin-it commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes

    • Resolved horizontal scrolling issue on the ticket details page.
  • Tests

    • Improved capacity limit e2e test reliability with enhanced polling logic and state refresh mechanisms.
  • Documentation

    • Added operational notes documenting test flakiness patterns and layout optimization insights.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ai-workflow-app (ai-workflow-demo) Ready Ready Preview, Comment Jun 18, 2026 11:31am
ai-workflow-app-dashboard Ready Ready Preview, Comment Jun 18, 2026 11:31am

Request Review

@kasin-it kasin-it merged commit 0c341b7 into main Jun 18, 2026
10 of 11 checks passed
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7222b3f8-49a2-4dc6-8d51-bcfc1de342f5

📥 Commits

Reviewing files that changed from the base of the PR and between 0118ecc and ef76a1d.

📒 Files selected for processing (4)
  • .claude/learnings.md
  • apps/dashboard/app/(cockpit)/ticket/[ticketKey]/page.tsx
  • apps/dashboard/components/cockpit/screens/ticket-selection.tsx
  • apps/worker/e2e/tier2/us11-capacity-limit-respected.test.ts

📝 Walkthrough

Walkthrough

Two independent fixes: the dashboard ticket detail column now uses minmax(0, 1fr) and min-w-0 to eliminate horizontal scrollbar overflow. The us11-capacity-limit-respected E2E test gains a saturateCapacity() helper and a retrying waitFor loop to handle Jira JQL eventual consistency, with both fixes documented in learnings.

Changes

Dashboard ticket grid overflow fix

Layer / File(s) Summary
Grid column sizing and min-width constraint
apps/dashboard/app/(cockpit)/ticket/[ticketKey]/page.tsx, apps/dashboard/components/cockpit/screens/ticket-selection.tsx, .claude/learnings.md
gridTemplateColumns changed from "280px 1fr" to "280px minmax(0, 1fr)" and min-w-0 added to DetailArea container to prevent the detail column from expanding beyond the viewport; fix documented in learnings.

US-11 E2E capacity-limit test hardening

Layer / File(s) Summary
saturateCapacity helper and beforeAll wiring
apps/worker/e2e/tier2/us11-capacity-limit-respected.test.ts
Adds saturateCapacity() that refreshes all dummy registry entries in parallel with fresh created_at timestamps; beforeAll now collects dummyKeys and calls it after seeding.
Retry loop replacing single cron poll
apps/worker/e2e/tier2/us11-capacity-limit-respected.test.ts, .claude/learnings.md
Replaces the single callCronPoll() call with a waitFor loop that re-saturates capacity before each attempt, asserts started === 0 every tick, and exits once discovered >= 1; Jira JQL eventual-consistency root cause documented in learnings.

Sequence Diagram(s)

sequenceDiagram
  participant waitFor as waitFor loop
  participant saturateCapacity as saturateCapacity()
  participant registry as Registry
  participant callCronPoll as callCronPoll()

  loop until discovered >= 1
    waitFor->>saturateCapacity: refresh dummy slots
    saturateCapacity->>registry: setEntry(key, fresh timestamp) × N in parallel
    registry-->>saturateCapacity: entries updated
    saturateCapacity-->>waitFor: capacity saturated
    waitFor->>callCronPoll: trigger cron tick
    callCronPoll-->>waitFor: { status:200, discovered, started }
    waitFor->>waitFor: assert started === 0
  end
  waitFor->>waitFor: assert started === 0, no run id in registry
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Blazity/ai-workflow#52: Directly related — both PRs harden cron poll logic for the us11 capacity-limit test, with overlapping changes to cron polling, discovered gating, and started === 0 assertions.

Poem

🐇 A grid that once bloated, now shrinks down with grace,
minmax(0, 1fr) keeps it all in its place.
The cron test was flaky, Jira slow to confess,
So I loop and re-saturate, poll till success!
With started === 0 on each hopeful tick,
This rabbit squashed flakiness, neat and quick. 🥕

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant