Basic Circuit recipe should only output IC2 circuits#1580
Open
MauveCloud wants to merge 4 commits intoBlood-Asp:unstablefrom
Open
Basic Circuit recipe should only output IC2 circuits#1580MauveCloud wants to merge 4 commits intoBlood-Asp:unstablefrom
MauveCloud wants to merge 4 commits intoBlood-Asp:unstablefrom
Conversation
Syncing from original.
Added some category methods so the run() method is less vulnerable to error messages about being too big. Added specific crafting recipe for IC2 circuit (see Blood-Asp#1574).
If loading sequence caused another mod's "basicCircuit" to be registered after IC2's, then that would be the only one craftable, making the GT good circuit uncraftable.
Realized it was a bad idea to do this in the same PR as other changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "non-removable" crafting recipe for IC2 circuits, and removes the code that could in some cases cause the crafting recipe to produce circuits from other mods (such as Mekanism) instead.
Also somewhat refactored GT_MachineRecipeLoader since I was changing that file anyway.This should help with #1574