Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix Relative Paths and Write Permissions with Temp Files #803

Conversation

nyoungbq
Copy link
Contributor

Naming Conventions

Naming of variables should descriptive where needed. Loop Control Variables can use i if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the file complex/docs/Code_Style_Guide.md for a more in depth explanation.

Filter Checklist

The help file complex/docs/Porting_Filters.md has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.

Unit Testing

The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:

  • 1 Unit test to test output from the filter against known exemplar set of data
  • 1 Unit test to test invalid input code paths that are specific to a filter. Don't test that a DataPath does not exist since that test is already performed as part of the SelectDataArrayAction.

Code Cleanup

  • No commented out code (rare exceptions to this is allowed..)
  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added example pipelines that use the filter
  • Classes and methods are properly documented

@nyoungbq nyoungbq force-pushed the bug/relative_paths_atomic_file branch from 41da161 to 35f8d55 Compare December 21, 2023 14:07
@nyoungbq nyoungbq force-pushed the bug/relative_paths_atomic_file branch from 35f8d55 to 3bbe48e Compare December 22, 2023 19:32
@imikejackson imikejackson force-pushed the bug/relative_paths_atomic_file branch from 667fb3d to 95e38fc Compare December 26, 2023 19:21
Copy link
Contributor

@imikejackson imikejackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't replicate the underlying issue on macOS on develop so I'm not sure exactly what this branch is fixing.

Until I can replicate the issue on any system I would like to leave this open.

@imikejackson imikejackson force-pushed the bug/relative_paths_atomic_file branch 2 times, most recently from 429918f to 9a752bc Compare January 14, 2024 17:37
@imikejackson imikejackson force-pushed the bug/relative_paths_atomic_file branch from 9a752bc to 0ea4a36 Compare January 30, 2024 17:32
@imikejackson imikejackson force-pushed the bug/relative_paths_atomic_file branch 2 times, most recently from 82bc958 to b0da6e2 Compare February 7, 2024 18:44
@imikejackson imikejackson force-pushed the bug/relative_paths_atomic_file branch from b0da6e2 to e4d5b1b Compare February 7, 2024 18:53
@imikejackson imikejackson force-pushed the bug/relative_paths_atomic_file branch from e4d5b1b to 683576c Compare February 9, 2024 22:19
@nyoungbq nyoungbq closed this Mar 29, 2024
@nyoungbq nyoungbq deleted the bug/relative_paths_atomic_file branch March 29, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants