-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fix Relative Paths and Write Permissions with Temp Files #803
Closed
nyoungbq
wants to merge
7
commits into
BlueQuartzSoftware:develop
from
nyoungbq:bug/relative_paths_atomic_file
Closed
BUG: Fix Relative Paths and Write Permissions with Temp Files #803
nyoungbq
wants to merge
7
commits into
BlueQuartzSoftware:develop
from
nyoungbq:bug/relative_paths_atomic_file
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41da161
to
35f8d55
Compare
f1927c5
to
95265d6
Compare
35f8d55
to
3bbe48e
Compare
imikejackson
approved these changes
Dec 26, 2023
667fb3d
to
95e38fc
Compare
imikejackson
requested changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't replicate the underlying issue on macOS on develop so I'm not sure exactly what this branch is fixing.
Until I can replicate the issue on any system I would like to leave this open.
429918f
to
9a752bc
Compare
9a752bc
to
0ea4a36
Compare
82bc958
to
b0da6e2
Compare
b0da6e2
to
e4d5b1b
Compare
e4d5b1b
to
683576c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming Conventions
Naming of variables should descriptive where needed. Loop Control Variables can use
i
if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the filecomplex/docs/Code_Style_Guide.md
for a more in depth explanation.Filter Checklist
The help file
complex/docs/Porting_Filters.md
has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.Unit Testing
The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:
Code Cleanup