Fixed params display in mainwindow and LCSC board value when removed #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issue Bouni#566. With this commit : - When LCSC value is removed from a component in the main window, the params display gets updated as well. - When LCSC value is removed from a component in the main window, the footprint's LCSC field is emptied as well, preventing the footprint from reloading its previous LCSC value into the database.
Improvement : when a component designator starts with an "R" and its value ends either with R (like in a 180R resistor), r (like a 180r resistor) or an o (like a 180o resistor), replace the last letter with the Omega symbol. Will work with different value ranges (kR, kr, ko, MR, Mr, Mo, whatever people use...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #566. With this commit :