[BRAH-70] Add Lyra Avalon Integration #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bapi-Reddy
requested changes
Jul 7, 2022
[BRAH-151] lyra pricing
Pradeep-selva
commented
Jul 20, 2022
contracts/LyraL2/LyraController.sol
Outdated
|
|
||
| if (positionData.state == LyraAdapter.PositionState.ACTIVE) { | ||
| (uint256 callPremium, uint256 putPremium) = LyraAdapter | ||
| ._getPurePremiumForStrike(currentPosition.strikeId); |
There was a problem hiding this comment.
@Bapi-Reddy this wont work for getting option price. What do we do in this case? For position in want token
Bapi-Reddy
reviewed
Jul 21, 2022
| sUSD.approve(address(lyraOptionMarket), sUSDBal); | ||
|
|
||
| if (updateExistingPosition) { | ||
| optionType = currentPosition.optionType; |
There was a problem hiding this comment.
update the previous purchased option amounts
Bapi-Reddy
reviewed
Jul 21, 2022
|
|
||
| sUSD.approve(address(lyraOptionMarket), sUSDBal); | ||
|
|
||
| if (updateExistingPosition) { |
There was a problem hiding this comment.
test this condition in unit tests
Bapi-Reddy
reviewed
Jul 21, 2022
| "NOT_ENOUGH_TOKENS" | ||
| ); | ||
|
|
||
| if (amountOut > 0) { |
There was a problem hiding this comment.
add a unit test for amountOut == 0
Bapi-Reddy
reviewed
Jul 21, 2022
Comment on lines
24
to
25
| INonfungiblePositionManager public constant nonfungiblePositionManager = | ||
| INonfungiblePositionManager(0xC36442b4a4522E871399CD717aBDD847Ab11FE88); |
Bapi-Reddy
reviewed
Jul 21, 2022
| @@ -0,0 +1,73 @@ | |||
| // SPDX-License-Identifier: GPL-2.0-or-later | |||
| pragma solidity ^0.8.0; | |||
0xad1onchain
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.