[scene_manager] Fix save_images not working with UTF-8 paths #450 #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Breakthrough
force-pushed
the
issue-450-path-handling
branch
from
22f8bcd to
e5e10d6
Compare
Breakthrough
force-pushed
the
issue-450-path-handling
branch
from
e5e10d6 to
e407607
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the OpenCV functions to read/write images doesn't seem to work nicely with Python strings. Instead we use other methods which are compatible with UTF-8 paths.
Fixes #450. Adds end-to-end test to verify the fix.