Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark run as module #489

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Benchmark run as module #489

merged 1 commit into from
Feb 21, 2025

Conversation

Breakthrough
Copy link
Owner

Allow running the benchmarks from the root of the repo as python -m benchmark so that it can work with a local development version of scenedetect.

@Breakthrough Breakthrough requested a review from awkrail February 20, 2025 03:19
Copy link
Collaborator

@awkrail awkrail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Breakthrough Breakthrough force-pushed the benchmark-run-as-module branch from 14c0631 to 82aba17 Compare February 21, 2025 02:13
This allows using the local `scenedetect` module rather than requiring it being installed. This is required to run the benchmarks with local changes during development.

Update instructions to run benchmarks accordingly.

Re-run all benchmarks on BBC dataset as they were originally calculated with the wrong ground truth.
@Breakthrough Breakthrough force-pushed the benchmark-run-as-module branch from 82aba17 to a709407 Compare February 21, 2025 02:38
@Breakthrough
Copy link
Owner Author

I've also re-run the benchmarks as discussed in #486.

@Breakthrough Breakthrough merged commit f196a31 into main Feb 21, 2025
1 check passed
@Breakthrough Breakthrough deleted the benchmark-run-as-module branch February 21, 2025 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants