[MI-3414]: add support for svg in webpack config + update components #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayusht2810
reviewed
Sep 12, 2023
ayusht2810
approved these changes
Sep 12, 2023
manojmalik20
approved these changes
Sep 12, 2023
…teams-sync into MI-3414
webapp/webpack.config.ts
Outdated
| { | ||
| test: /\.svg$/, | ||
| issuer: /\.[jt]sx?$/, | ||
| use: ['@svgr/webpack', 'url-loader'], |
There was a problem hiding this comment.
This is removing the viewbox from the svgs in the plugin.
See the screenshot -
The viewbox is present in the mm-ui-library but is removed here.
manojmalik20
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing steps
make diston this branch on local. (this will create tar file in a dist folder)menu > system console > plugin management > Upload Plugin