upgrade to node v18, GHA #32
Conversation
venkata-ramana-d2l
force-pushed
the
venkata/use-gha-node-increment
branch
from
d8a8bbb to
0b36ae0
Compare
.github/workflows/ci.yml
Outdated
| with: | ||
| node-version-file: .nvmrc | ||
| - name: Install dependencies | ||
| run: npm install |
There was a problem hiding this comment.
npm ci is more appropriate for CI jobs
| run: npm install | |
| run: npm ci |
There was a problem hiding this comment.
agree, was just testing stuff. will eventually change it to ci
.github/workflows/ci.yml
Outdated
| - name: Build Sample | ||
| run: npm run build-sample | ||
| - name: Report Coverage | ||
| run: npm run report-coverage |
.github/workflows/release.yml
Outdated
| DEFAULT_BRANCH: master | ||
| GITHUB_TOKEN: ${{ secrets.D2L_GITHUB_TOKEN }} | ||
| NPM: true | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} |
.nvmrc
Outdated
| @@ -0,0 +1 @@ | |||
| 18 | |||
.gitignore
Outdated
| @@ -3,3 +3,4 @@ coverage | |||
| sample/dist | |||
| node_modules | |||
| npm-debug.log | |||
| package-lock.json | |||
There was a problem hiding this comment.
Why are you excluding package-lock.json?
There was a problem hiding this comment.
so, I made this PR in this repo from #31 as it being a PR from forked repo, it was not triggering Actions. First i wanted to test this part whether the Actions are being triggered and if the pipeline is successful.
Even i was not sure why was package-log excluded. Will check that and remove this change.
| @@ -1,19 +0,0 @@ | |||
| language: node_js | |||
| node_js: | |||
| - 10 | |||
There was a problem hiding this comment.
The old CI was using Node 10, while the new one is at 18. This is likely the cause of failures. You'll likely need to update dependencies for Node 18 to work.
No description provided.