Skip to content

fix: submodules best practices#3772

Merged
MrAlex94 merged 1 commit intoBrowserWorks:currentfrom
T0nd0Tara:bugfix/clone-with-recursive-doesnt-work-properly
Jun 3, 2025
Merged

fix: submodules best practices#3772
MrAlex94 merged 1 commit intoBrowserWorks:currentfrom
T0nd0Tara:bugfix/clone-with-recursive-doesnt-work-properly

Conversation

@T0nd0Tara
Copy link
Copy Markdown
Contributor

I've noticed cloning the project for the first time using git clone --depth=1 --recursive https://github.com/BrowserWorks/Waterfox.git

I get an error that I dont have permissions for a submodule git@github.com:BrowserWorks/l10n.git

fatal: clone of 'git@github.com:BrowserWorks/l10n.git' into submodule path '...' failed
Failed to clone 'waterfox/browser/locales'. Retry scheduled
...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:BrowserWorks/l10n.git' into submodule path '...' failed
Failed to clone 'waterfox/browser/locales' a second time, aborting

I'm sure there is a way to configure git to be able to clone with this format. None the less, I believe this change would make it easier for new contributors cloning for the first time

Signed-off-by: T0nd0Tara <52151795+T0nd0Tara@users.noreply.github.com>
@MrAlex94 MrAlex94 merged commit 7f8bf3c into BrowserWorks:current Jun 3, 2025
7 of 10 checks passed
@MrAlex94
Copy link
Copy Markdown
Collaborator

MrAlex94 commented Jun 3, 2025

Thanks! Have been meaning to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants