Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support windows files with spaces, more warnings #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

1enu
Copy link

@1enu 1enu commented Oct 6, 2023

Note: I am not experienced with typescript, feel free to edit/format if there are any errors or better ways of doing this.

  • Added support for windows files with spaces in their name.
    • I have tried string escaping/using double quotations in the file path but it does not work.
    • I did it by changing directory temporarily, then change back after the executable is spawned. This way, we can preserve using child_process.spawn.
  • Added more messages when busted fails to spawn on windows.
    • If it fails to spawn:
      • Warns that changing PATH file might need a VSCode/system restart to take effect.
      • If busted executable config has no file extension (ex. busted):
        • Notifies through test results to include the file extension(ex. .bat) if your executable is not an exe file

          Example: I use busted.bat as executable, which will not be recognized using the default "busted" as configuration even if it is on PATH(it is runs in vscode terminal/cmd just fine)

          Solution: type busted.bat explicitly in the configuration as it is not an exe file

    • Should give unable to find busted executable #3 more info regarding their problem.

@1enu 1enu changed the title Support windows files with spaces, more warnings [WIP]Support windows files with spaces, more warnings Oct 6, 2023
@1enu
Copy link
Author

1enu commented Oct 6, 2023

WIP: invalid directory input causes a "rejected promise not handled" and does not halt testing.

@1enu 1enu changed the title [WIP]Support windows files with spaces, more warnings Support windows files with spaces, more warnings Oct 6, 2023
@1enu
Copy link
Author

1enu commented Oct 6, 2023

WIP: invalid directory input causes a "rejected promise not handled" and does not halt testing.

Rejected promises are now properly catched and displayed accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant