Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: Allow custom prefixes for third-party packages #660

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

bobby285271
Copy link
Contributor

@bobby285271 bobby285271 commented Jan 22, 2025

Description

labwc, magpie, gsd does not always share the same prefix as budgie-desktop and sometimes they are just installed in some unusual paths. For example:

  • In NixOS labwc is installed in /nix/store/xxx-labwc-0.8.2/bin.
  • In Arch Linux gsd-media-keys is installed in /usr/lib/ (reference).

Simply don't hardcode these paths.

Submitter Checklist

  • Squashed commits with git rebase -i (if needed)
  • Built budgie-desktop and verified that the patch worked (if needed)

@bobby285271 bobby285271 marked this pull request as draft January 25, 2025 13:40
labwc, magpie, gsd does not always share the same prefix as
budgie-desktop and sometimes they are just installed in some
unusual paths. For example, in NixOS labwc is installed in
/nix/store/xxx-labwc-0.8.2/bin, and in Arch Linux gsd-media-keys
is installed in /usr/lib/. Simply don't hardcode these paths.
@bobby285271 bobby285271 marked this pull request as ready for review January 25, 2025 13:49
Copy link
Contributor

@fossfreedom fossfreedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate the effort here. Makes total sense. Cheers!

@fossfreedom fossfreedom merged commit c311a60 into BuddiesOfBudgie:main Feb 11, 2025
1 check failed
@bobby285271 bobby285271 deleted the meson-fixes branch February 12, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants