Skip to content

Conversation

@portdeveloper
Copy link
Member

@portdeveloper portdeveloper commented Jul 11, 2025

Improves link checks in playwrights tests, solves one error when running tests

fixes #87

@vercel
Copy link

vercel bot commented Jul 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
address-vision-port ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2025 8:22am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the Playwright test for the Address page to perform a case-insensitive URL check, resolving a failure when URLs differ by casing.

  • Normalize the page URL and testAddress to lowercase before asserting
  • Replace the previous direct .url().toContain with a two-step lowercase extraction and assertion
Comments suppressed due to low confidence (1)

packages/nextjs/tests/address.spec.ts:30

  • [nitpick] The variable name url is very generic; consider renaming it to pageUrl or actualUrl to improve clarity.
    const url = newPage.url().toLowerCase();

@portdeveloper portdeveloper merged commit ceca81d into main Aug 2, 2025
3 checks passed
@portdeveloper portdeveloper deleted the fix/link-checks-in-tests branch August 2, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: tests fail due to weird links

2 participants