Skip to content

Explicit pointer casts#245

Open
Un1q32 wants to merge 4 commits into
ButterscotchRunner:mainfrom
Un1q32:stdcxx
Open

Explicit pointer casts#245
Un1q32 wants to merge 4 commits into
ButterscotchRunner:mainfrom
Un1q32:stdcxx

Conversation

@Un1q32

@Un1q32 Un1q32 commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Adds explicit pointer casts everywhere.
Also adds a C++ workflow.

@Un1q32 Un1q32 force-pushed the stdcxx branch 2 times, most recently from 6ef2995 to ccac8ac Compare June 19, 2026 18:45
@Un1q32

Un1q32 commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator Author

This is ready once #233 is in.

@Un1q32 Un1q32 force-pushed the stdcxx branch 7 times, most recently from 5bafdb3 to ad2239c Compare June 24, 2026 22:13
@Un1q32 Un1q32 marked this pull request as ready for review June 24, 2026 22:14
@Un1q32 Un1q32 marked this pull request as draft June 24, 2026 22:25
@Un1q32 Un1q32 mentioned this pull request Jun 24, 2026
@Un1q32

Un1q32 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

My plan for this PR now is to make separate PRs with all the bits that aren't the explicit pointer casts, because the explicit pointer casts are most of the diff.
Explicit pointer casts also have the benefit of not changing codegen so I can just build before and after and if the binary hash doesn't change then it's almost certainly not breaking anything accidentally.

@Un1q32 Un1q32 marked this pull request as ready for review June 25, 2026 23:20
@Un1q32 Un1q32 changed the title Standard C++ Explicit pointer casts Jun 25, 2026
@Un1q32

Un1q32 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator Author

This is just explicit pointer casts now, the binary hash is identical before and after so codegen definitely isn't changed.
I'll leave this open for a day so if anyone wants to make sure there's nothing wrong with the workflow or anything, and if nobody objects to anything I'll merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant