Explicit pointer casts#245
Open
Un1q32 wants to merge 4 commits into
Open
Conversation
Closed
6ef2995 to
ccac8ac
Compare
Collaborator
Author
|
This is ready once #233 is in. |
5bafdb3 to
ad2239c
Compare
Merged
Collaborator
Author
|
My plan for this PR now is to make separate PRs with all the bits that aren't the explicit pointer casts, because the explicit pointer casts are most of the diff. |
Collaborator
Author
|
This is just explicit pointer casts now, the binary hash is identical before and after so codegen definitely isn't changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit pointer casts everywhere.
Also adds a C++ workflow.