Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redux - 414 merge am3 miscellaneous science modifications #439

Closed
wants to merge 26 commits into from
Closed

redux - 414 merge am3 miscellaneous science modifications #439

wants to merge 26 commits into from

Conversation

JhanSrbinovsky
Copy link
Collaborator

@JhanSrbinovsky JhanSrbinovsky commented Oct 29, 2024 •
edited by github-actions bot
Loading

CABLE

PR #430 was accepted but comparison was made to branch corresponding to issue #402 NOT main.

Fixes #414

Include AM3 developments

Checklist

  • The new content is accessible and located in the appropriate section.
  • I have checked that links are valid and point to the intended content.
  • I have checked my code/text and corrected any misspellings

📚 Documentation preview 📚: https://cable--439.org.readthedocs.build/en/439/

@JhanSrbinovsky
coupled - this appliation directory SHOULD have nothing to do with th…
e0642e9 
…e rest of the model
@JhanSrbinovsky
manually merge changes from AM3
042cc34
@JhanSrbinovsky
add ice_cable index to grid_constants
b5bf063
@JhanSrbinovsky
Merge remote-tracking branch 'origin/363_params' into 402-merge-from-…
7357d0a 
…am3-params
@JhanSrbinovsky
aliased constant
ce268a7
@JhanSrbinovsky
merged update trunk to incl 8f62897
79504d2
@JhanSrbinovsky
move definition of nCNPpool_tile TYPE members dimensions to coupled/
d2d4610 
which is the only place it is used
@JhanSrbinovsky
offline define parameters which in JAC are read through
e089037 
cable_surface_type_namelist - which will be implemented here as well at
a later date
@JhanSrbinovsky
Merge branch '412-initialize-dimensions-of-cnp-pools-following-am3' i…
aa6f453 
…nto 402-merge-from-am3-params
@JhanSrbinovsky
not strictly needed for offline to work - however corresponding mod to
7fef241 
that in grid_constants
@JhanSrbinovsky
Merge branch '402-merge-from-am3-params' into 414-merge-am3-miscellan…
893e9d7 
…eous-science-modifications
@JhanSrbinovsky
remove redundant code - no need to comment
f8e5d26
@JhanSrbinovsky
remove redundant code - no need to comment
e86bc52
@JhanSrbinovsky
modifications from AM3 development - will change output
b466ab8
@JhanSrbinovsky
modifications from AM3 development
657a839
@JhanSrbinovsky
likely change in regression testing due to correction factors sqitched
b729a81 
off and ICE density used that has changed as well
@JhanSrbinovsky
modifications from AM3 development
0c45c93
@JhanSrbinovsky
only used in GW
c23bc77
@JhanSrbinovsky
revert these to main: versions
31d553d
@JhanSrbinovsky
oops retain this mod from params
eece93f
@JhanSrbinovsky
AM3 version
93c8033
@JhanSrbinovsky
AM3 version
0b16877
@JhanSrbinovsky
AM3 version
7806c97
@JhanSrbinovsky
revert to main: version
bc0ed32
@JhanSrbinovsky
revert to main: version
467902a
@JhanSrbinovsky JhanSrbinovsky self-assigned this Nov 6, 2024
@JhanSrbinovsky JhanSrbinovsky added the priority:high High priority issues that should be included in the next release. label Nov 6, 2024
@JhanSrbinovsky JhanSrbinovsky added this to the ESM1.6 FastTrack milestone Nov 6, 2024
@JhanSrbinovsky
Copy link
Collaborator Author

necessary mods have found there way in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JhanSrbinovsky JhanSrbinovsky

Labels
priority:high High priority issues that should be included in the next release.
Projects
None yet
Milestone
ESM1.6 FastTrack
Development

Successfully merging this pull request may close these issues.

Merge AM3 (miscellaneous) science modifications
1 participant
@JhanSrbinovsky