Bring up to date with ACCESS3 science#729
Conversation
|
I'll wait for comment from @har917 before I approve |
|
|
||
| ! soilsnow_init_spec, special initalizations in um_init NA for ESM1.5 | ||
|
|
||
| xx=soil%css * soil%rhosoil |
There was a problem hiding this comment.
Where is the equivalent bit of science in the library - i.e. where is %gamzz being initialised on the first call in offline and AM3 (likely um_init_soilsnow)?
There was a problem hiding this comment.
Apparently this is now stored in the restart. We had a long conversation about this in the JULES PR, and the gist was that this bit of code can be removed. In offline mode, we call spec_init_soil_snow from the driver which overrides this anyway.
aargh - this brings back "war" memories which I have (thankfully) mostly forgotten. For definite - For But probably worth looking through the issue/PR around temperature oscillations. |
|
I found the relevant issue- seems the current form is the one that was deemed to be most accurate i.e. not using |
|
I'll do a quick benchcab run to make sure nothing unexpected has happened. If it shows no differences, I'll merge. |
|
Benchcab reports identical results. |
CABLE
Thank you for submitting a pull request to the CABLE Project.
Description
These are the science changes that occurred in the CABLE code that sits within JULES for AM3, that we want to move into the library. The changes removing the calculation of
gamzzandtrad_corrwere discussed in the CABLE science update PR, here and here. I had missed the change from usingssnow%otsstosnow%tssin thesoil_tradcalculation, but appears to be a deliberate change from this JULES commit.I am a little confused though- in your comment here @har917, you said that the
trad_corris still required in theimplcall, but this JULES commit removes it from bothexplandimplcall. Should thetrad_corrbe re-introduced to theimplcall?It may also be preferred to leave
cbl_cbm_mod.F90within JULES- at the moment, I only moved it since it lived in the same directory as all the geophysics type definitions, which must live within the library, but this isn't required for any of the science code. It may make more sense to leave it within JULES.Testing
2026-07-03 12:23:52,415 - INFO - benchcab.benchcab.py:391 - 0 failed, 168 passed
📚 Documentation preview 📚: https://cable--729.org.readthedocs.build/en/729/