Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/modify priceticker #21

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Feature/modify priceticker #21

merged 5 commits into from
Apr 19, 2024

Conversation

RexBearIU
Copy link
Contributor

@RexBearIU RexBearIU commented Apr 12, 2024 •
edited
Loading

DEVELOP

change priceticker logic to be singleton to migate the pressure for tbd-backend

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

This was linked to issues Apr 12, 2024
change code to meet the coding sytle CAFECA-IO/TideBit-DeFi#1585
Closed
Change the tradebot get priceticker logic CAFECA-IO/TideBit-DeFi#1582
Closed
run trade bot to test the new logic CAFECA-IO/TideBit-DeFi#1583
Closed
Luphia
Luphia approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 713894a into develop Apr 19, 2024
0 of 2 checks passed
@Luphia Luphia deleted the feature/modify_priceticker branch April 19, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

Assignees

@RexBearIU RexBearIU

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@RexBearIU @Luphia