Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH 2431 #238

Open
wants to merge 5 commits into
base: 3.3.0
Choose a base branch
from
Open

CRDCDH 2431 #238

wants to merge 5 commits into from

Conversation

vshand11
Copy link
Collaborator

  1. implemented CRDCDH2431.
  2. add index, synonym_1, in synonyms collection.
  3. updated mongo DAO function, find_pvs_by_synonym.
  4. updated mongo_db_script/restoreErrorCodeInQCResults.js

vshand11 added 5 commits March 7, 2025 14:46

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@vshand11 vshand11 requested a review from n2iw March 11, 2025 13:50
self.log.error(msg)
return FAILED
self.study_name = study.get("studyName")
program = submission.get("organization")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"organization" property in Submission should be removed. Please find program via study_id only.

@@ -322,6 +345,23 @@ def validate_required_props(self, data_record, msg_prefix):
if anode_definition["properties"][data_key]["required"]:
if data_value is None or not str(data_value).strip():
result[ERRORS].append(create_error("M003",[msg_prefix, data_key], data_key, data_value))
else:
# validate program name and study name required in CRDCDH-2431. Both are required properties.
if node_type == "program" and data_key == "program_name":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use entityType instead of node type, because node type can be different in different data commons. Same for the property name, we probably need to add some new configurations in model repo's content.json to configure property names.

else:
data_record[PROPERTIES][data_key] = matched_val

if node_type in ["study"] and data_key in ["study_name", "clinical_study_name"]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above comment, that study node name can be different among data commons, same as the name property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants