-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH 2431 #238
base: 3.3.0
Are you sure you want to change the base?
CRDCDH 2431 #238
Conversation
vshand11
commented
Mar 11, 2025
- implemented CRDCDH2431.
- add index, synonym_1, in synonyms collection.
- updated mongo DAO function, find_pvs_by_synonym.
- updated mongo_db_script/restoreErrorCodeInQCResults.js
self.log.error(msg) | ||
return FAILED | ||
self.study_name = study.get("studyName") | ||
program = submission.get("organization") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"organization" property in Submission should be removed. Please find program via study_id only.
@@ -322,6 +345,23 @@ def validate_required_props(self, data_record, msg_prefix): | |||
if anode_definition["properties"][data_key]["required"]: | |||
if data_value is None or not str(data_value).strip(): | |||
result[ERRORS].append(create_error("M003",[msg_prefix, data_key], data_key, data_value)) | |||
else: | |||
# validate program name and study name required in CRDCDH-2431. Both are required properties. | |||
if node_type == "program" and data_key == "program_name": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use entityType instead of node type, because node type can be different in different data commons. Same for the property name, we probably need to add some new configurations in model repo's content.json to configure property names.
else: | ||
data_record[PROPERTIES][data_key] = matched_val | ||
|
||
if node_type in ["study"] and data_key in ["study_name", "clinical_study_name"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to above comment, that study node name can be different among data commons, same as the name property.