Included projects belonging to MGHPCC-managed groups in the NERC total invoice #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikolla
reviewed
Jan 10, 2025
| @@ -60,4 +60,5 @@ def _prepare_export(self): | |||
| ] | |||
| self.data = self.data[ | |||
| self.data[invoice.INSTITUTION_FIELD].isin(self.INCLUDED_INSTITUTIONS) | |||
| | (self.data[invoice.GROUP_MANAGED_FIELD] == True) # noqa E712 | |||
There was a problem hiding this comment.
Is this loaded as a boolean from the csv?
There was a problem hiding this comment.
Thank you for pointing this out. I rechecked and realized that the MGHPCC Managed field is loaded as a string ("Yes" or "No"). I could fix the code to map the strings into a Boolean (True for "Yes", etc) or I could fix this condition to == "Yes". @knikolla What do you think?
There was a problem hiding this comment.
If the CSV file has them as "yes", "no" and this is the only place they're being used, then a comparison with .lower() == "yes" is enough.
QuanMPhm
force-pushed
the
125/prepay_nerc_total
branch
from
9724494 to
30dfb47
Compare
knikolla
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125. Consists of the last commit