Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse identifiers for comparisons #211

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Conversation

m-goggins
Copy link
Collaborator

@m-goggins m-goggins commented Feb 10, 2025

Description

Since Jaro-Winkler is the default similarity measure for string comparisons, more weight is given to differences at the start of a string. As such, this PR modifies the way that we yield and store Identifiers for comparison. Previously, the Identifier format was type:authority:value but now it is value:authority:type to give more weight to the value. For example, when comparing two MRNs with values, 1234 and 2345, we will now give more weight to 1234 vs 2345 than the type, e.g., MR vs MR. This should yield better differentiation between strings.

Related Issues

Fixes #200

Additional Notes

I updated the language in the RFC to reflect the new format and added a note at the bottom to indicate that the RFC has been changed.

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.65%. Comparing base (1507bea) to head (c4fb31e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   97.65%   97.65%           
=======================================
  Files          32       32           
  Lines        1576     1576           
=======================================
  Hits         1539     1539           
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m-goggins m-goggins marked this pull request as ready for review February 10, 2025 21:59
ericbuckley
ericbuckley previously approved these changes Feb 10, 2025
@m-goggins m-goggins merged commit ba4c2ae into main Feb 10, 2025
15 checks passed
@m-goggins m-goggins deleted the fix/200/reverse-identifiers branch February 10, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reverse Identifier for comparisons
2 participants