-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC-003: skip values #218
base: main
Are you sure you want to change the base?
RFC-003: skip values #218
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 97.65% 97.69% +0.04%
==========================================
Files 32 32
Lines 1618 1651 +33
==========================================
+ Hits 1580 1613 +33
Misses 38 38 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the approach generally but wanted to flag a possible concern around using NAME rather than jointly considering First and Last. Nothing that's blocker level, but just raising.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think we're there with this!
Description
A proposal to introduce system changes allowing users to define skip conditions for placeholder values to be ignored during the linkage process.
Related Issues
closes #215
<--------------------- REMOVE THE LINES BELOW BEFORE MERGING --------------------->
Checklist
Please review and complete the following checklist before submitting your pull request:
Checklist for Reviewers
Please review and complete the following checklist during the review process: